Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make border classes more atomic-friendly #76

Closed
thierryk opened this issue Mar 9, 2015 · 4 comments
Closed

Make border classes more atomic-friendly #76

thierryk opened this issue Mar 9, 2015 · 4 comments

Comments

@thierryk
Copy link
Contributor

thierryk commented Mar 9, 2015

We have the following helper classes:

.Bd-0 {
    border: 0;
}
.Bd-1,
.Bdx-1,
.Bdy-1,
.Bdt-1,
.Bdend-1,
.Bdb-1,
.Bdstart-1 {
    border-width: 0;
    border-style: solid;
}
.Bdstart-1 {
    border-left-width: 1px;
}
.Bdend-1 {
    border-right-width: 1px;
}
.Bdx-1 {
    border-right-width: 1px;
    border-left-width: 1px;
}
.Bdy-1 {
    border-top-width: 1px;
    border-bottom-width: 1px;
}

But I think we should move all this to rules.js — using classes like Bdw-, Bds-, Bdc-.
That way users can create border styling without having to create custom Atomic classes.

Thoughts?

@src-code
Copy link
Contributor

src-code commented Mar 9, 2015

PR #74 already adds most of this, just needs the Bdy and Bdx support added.

@src-code
Copy link
Contributor

Resolved in #74

@thierryk
Copy link
Contributor Author

For the record: helpers.css (from another repo) has been updated with border classes meant to help when styling boxes with a single pixel border but those rules need to integrate Atomizer somehow.

@src-code
Copy link
Contributor

@thierryk I'll add a new issue for that.

redonkulus pushed a commit that referenced this issue Jul 14, 2022
redonkulus pushed a commit that referenced this issue Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants