Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 links different destination same acc name is passing, should discuss [b20e66] #1248

Closed
DavidMacDonald opened this issue Mar 26, 2020 · 2 comments

Comments

@DavidMacDonald
Copy link

2.4.4 requires description of destination. 2 identical ACCNAMES with dif destination is not sufficient description I would say... but its grey, let's discuss.
Links with identical accessible names have equivalent purpose - Passed Example 7

https://www.davidmacd.com/auto-test-files/act-mar17/testcases/b20e66/ffd847275f8d2d4537d7f7346be39a226e33fbea.html
https://act-rules.github.io/rules/b20e66

@WilcoFiers
Copy link
Member

Hey David. We've talked about it in the CG today. The group seems a little divided on this issue. Not as much about example 7, which most seem to agree should pass the SC, but about the difference between passed example 4 and failed example 2. A number of people in the group seem to think the difference between the two is too small to justify one as a failure and the other as a pass.

One thing that needs to be done here is to improve the examples. A lot of context is missing from the examples, making it difficult to gage. I'm not sure that fully addresses the issue, but that's where we'll start. We'll see how far that gets us.

@WilcoFiers
Copy link
Member

BTW, looking for someone to pick up this issue. If anyone is interested, feel free to open a pull request.

@WilcoFiers WilcoFiers changed the title 2 links different destination same acc name is passing, should discuss 2 links different destination same acc name is passing, should discuss [b20e66] Jun 8, 2020
HelenBurge added a commit to HelenBurge/act-rules.github.io that referenced this issue Sep 26, 2020
I would like my addition to passed example 11 to be confirmed, as was not clear to me... Despite reading the definitions (I tried to make it less technical for others like me!)

I might have over described what may seem obvious, to clarify the reason for passes/fails as per act-rules#1248
WilcoFiers added a commit that referenced this issue Nov 2, 2020
…66): Prepare for TF review (#1463)

* #1248-updates

I would like my addition to passed example 11 to be confirmed, as was not clear to me... Despite reading the definitions (I tried to make it less technical for others like me!)

I might have over described what may seem obvious, to clarify the reason for passes/fails as per #1248

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update links-identical-name-equivalent-purpose-b20e66.md

Amended the rule "Inapplicable Example 1" from feedback

* Update _rules/links-identical-name-equivalent-purpose-b20e66.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/links-identical-name-equivalent-purpose-b20e66.md

Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>

* Update _rules/links-identical-name-equivalent-purpose-b20e66.md

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

Co-authored-by: Jey <jey.nandakumar@gmail.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants