Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"role attribute has valid value" (674b10): make rule inapplicable if there isn't at least one role #1277

Merged
merged 3 commits into from May 1, 2020

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Apr 23, 2020

Make rule inapplicable on role=" " because whitespace only role attribute is treated as empty one (there is no token in the set of space separated tokens).

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (upgrade in applicability, changes one example)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Apr 23, 2020
@Jym77 Jym77 self-assigned this Apr 23, 2020
@Jym77 Jym77 changed the title Make rule inapplicable if there isn't at least one role "role attribute has valid value" (674b10): make rule inapplicable if there isn't at least one role Apr 23, 2020
_rules/role-attribute-valid-value-674b10.md Outdated Show resolved Hide resolved
Co-Authored-By: Kasper Isager <kasperisager@gmail.com>
@Jym77
Copy link
Collaborator Author

Jym77 commented Apr 24, 2020

Final Call ends on May 1st.

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Apr 24, 2020
@Jym77
Copy link
Collaborator Author

Jym77 commented May 1, 2020

Final Call has ended. Merging.

@Jym77 Jym77 merged commit b008b3c into develop May 1, 2020
@Jym77 Jym77 deleted the rolet-attribute-valid-whitespace branch May 1, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed example 3 wrong for 'role attribute has valid value'
4 participants