Fixing screen reader heuristics issues with examples in "Headers attribute specified on a cell refers to cells in the same table element" #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanec01
changed the title
ajanec01
added
Editorial
ajanec01
requested review from
EmmaJP,
Jym77,
WilcoFiers,
adilsofficial,
carlosapaduarte and
jeeyyy
and removed request for
jeeyyy
Jym77
previously requested changes
Nov 17, 2020
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
Collaborator
|
@ajanec01 is this good for another review or do you need to work some more on it? |
Collaborator
Author
|
Hey @Jym77 I still need to fix the failed checks which I will look into today. Other than that, it is ready for another review. Thanks |
Collaborator
|
👍 Let me know if you need help with the test. |
Collaborator
Author
|
Hey @Jym77 |
WilcoFiers
approved these changes
Nov 24, 2020
Member
WilcoFiers
left a comment
WilcoFiers
left a comment
There was a problem hiding this comment.
Looks good, nice work Aron. Thanks!
daniel-montalvo
approved these changes
Nov 27, 2020
Collaborator
daniel-montalvo
left a comment
daniel-montalvo
left a comment
There was a problem hiding this comment.
Minor considerations in example descriptions, otherwise approving.
Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: daniel-montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Collaborator
Author
|
Suggestions committed, thanks @daniel-montalvo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few changes made in response to #1195
Tested using the following combinations:
The JAWS and Firefox combination is not working as not even the contents of the table are announced. The other combinations worked as expected.
Need for Final Call: None.
Closes issue(s):