Skip to content

"Element with lang attribute has valid language tag" (de46e4): Apply to body and ignore attributes with no effect - #1547

Merged
Jym77 merged 11 commits into
developfrom
element-lang-valid-fix-and-polish
Jun 17, 2021
Merged

Jym77 merged 11 commits into
developfrom
element-lang-valid-fix-and-polish

Conversation

@Jym77

@Jym77 Jym77 commented Feb 11, 2021

Copy link
Copy Markdown
Collaborator

Align the "lang valid" rule with the newer "lang matches default" one by

  • also applying on body itself;
  • only checking lang attributes who affect some text.

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (small fixes to Applicability)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels Feb 11, 2021
@Jym77 Jym77 self-assigned this Feb 11, 2021

@carlosapaduarte carlosapaduarte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some colons missing

Comment thread _rules/element-lang-valid-de46e4.md Outdated
Comment thread _rules/element-lang-valid-de46e4.md Outdated
Comment thread _rules/element-lang-valid-de46e4.md Outdated
Jym77 and others added 2 commits May 10, 2021 10:06
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jun 10, 2021
@Jym77

Jym77 commented Jun 10, 2021

Copy link
Copy Markdown
Collaborator Author

Call for review ends on June 17th.

@Jym77

Jym77 commented Jun 17, 2021

Copy link
Copy Markdown
Collaborator Author

Call for review ended. Merging.

@Jym77
Jym77 merged commit 93d9dbf into develop Jun 17, 2021
@Jym77
Jym77 deleted the element-lang-valid-fix-and-polish branch June 17, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

5 participants