Repository navigation
"Element with lang attribute has valid language tag" (de46e4): Apply to body and ignore attributes with no effect - #1547
Merged
Conversation
Jym77
requested review from
EmmaJP,
ShadowBB,
WilcoFiers,
ajanec01,
annethyme,
carlosapaduarte,
daniel-montalvo and
jeeyyy
February 11, 2021 10:16
ajanec01
approved these changes
Feb 21, 2021
WilcoFiers
approved these changes
Apr 12, 2021
carlosapaduarte
previously requested changes
May 7, 2021
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
carlosapaduarte
approved these changes
Jun 2, 2021
Collaborator
Author
|
Call for review ends on June 17th. |
colabottles
approved these changes
Jun 10, 2021
Collaborator
Author
|
Call for review ended. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the "lang valid" rule with the newer "lang matches default" one by
bodyitself;langattributes who affect some text.Closes issue(s):
langattribute has valid language tag" (de46e4): Should it check accessible names? #1520langattribute has valid language tag" (de46e4) fails on nested attribute #1525Need for Final Call:
This will require a 1 week Final Call (small fixes to Applicability)
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve