Skip to content

"role attribute has valid value" (674b10): Replace 'included in the accessibility tree' with 'hidden state is false' - #1631

Merged
Jym77 merged 3 commits into
developfrom
role-valid-replace-accessibility-tree-with-not-hidden
Jun 17, 2021
Merged

Jym77 merged 3 commits into
developfrom
role-valid-replace-accessibility-tree-with-not-hidden

Conversation

@Jym77

@Jym77 Jym77 commented May 27, 2021

Copy link
Copy Markdown
Collaborator

Replace "included in the accessibility tree" requirement, which was causing some weird issues with containers, with "whose hidden state is false".

Closes issue(s):

Need for Final Call:
This will require a 1 week Final Call (small change in Applicability)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Rule Update Use this label for an existing rule that is being updated reviewers wanted labels May 27, 2021
@Jym77 Jym77 self-assigned this May 27, 2021
@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Jun 10, 2021
@Jym77

Jym77 commented Jun 10, 2021

Copy link
Copy Markdown
Collaborator Author

Call for review ends on June 17th.

@Jym77

Jym77 commented Jun 17, 2021

Copy link
Copy Markdown
Collaborator Author

Call for review has ended. Merging.

@Jym77
Jym77 merged commit 8db2d9b into develop Jun 17, 2021
@Jym77
Jym77 deleted the role-valid-replace-accessibility-tree-with-not-hidden branch June 17, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"role attribute has valid value" (674b10): Failed Example 1 and 2 are incorrect

5 participants