Repository navigation
"role attribute has valid value" (674b10): Replace 'included in the accessibility tree' with 'hidden state is false' - #1631
Merged
Jym77 merged 3 commits intoJun 17, 2021
Conversation
Jym77
requested review from
EmmaJP,
WilcoFiers,
ajanec01,
annethyme,
carlosapaduarte and
daniel-montalvo
May 27, 2021 13:45
WilcoFiers
approved these changes
May 31, 2021
ajanec01
approved these changes
May 31, 2021
carlosapaduarte
approved these changes
Jun 2, 2021
Collaborator
Author
|
Call for review ends on June 17th. |
colabottles
approved these changes
Jun 10, 2021
Collaborator
Author
|
Call for review has ended. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "included in the accessibility tree" requirement, which was causing some weird issues with containers, with "whose hidden state is false".
Closes issue(s):
Need for Final Call:
This will require a 1 week Final Call (small change in Applicability)
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve