From b39ddfb90f5c8af61ff504a6672ee95266c744de Mon Sep 17 00:00:00 2001 From: Tom Brunet Date: Tue, 19 Apr 2022 14:53:09 -0500 Subject: [PATCH 1/5] Adjust meta applicability based on properties defined --- _rules/meta-viewport-b4f0c3.md | 74 +++++++++++++++++----------------- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/_rules/meta-viewport-b4f0c3.md b/_rules/meta-viewport-b4f0c3.md index d5cbc710786..4beda9fa31a 100755 --- a/_rules/meta-viewport-b4f0c3.md +++ b/_rules/meta-viewport-b4f0c3.md @@ -22,7 +22,7 @@ acknowledgments: ## Applicability -This rule applies to each `meta` element with a `name` attribute whose value is a [case-insensitive][] match for `viewport` and has a `content` attribute. +This rule applies to each `meta` element with a `name` attribute whose value is a [case-insensitive][] match for `viewport` and has a `content` attribute. In addition, when the `content` attribute value is mapped to a list of property/value pairs in a user-agent specific manner, one of the properties is either `user-scalable` or `maximum-scale`. ## Expectation @@ -60,13 +60,13 @@ This rule is designed specifically for [1.4.4 Resize text][sc144], which require #### Passed Example 1 -This viewport `meta` element does not prevent user scaling because it does not specify the `maximum-scale` and `user-scalable` values. +This viewport `meta` element does not prevent user scaling because it has `user-scalable` set to `yes`. ```html Simple page showing random text - +

@@ -78,13 +78,13 @@ This viewport `meta` element does not prevent user scaling because it does not s #### Passed Example 2 -This viewport `meta` element does not prevent user scaling because it has `user-scalable` set to `yes`. +This viewport `meta` element allows users to scale content up to 600% because it has `maximum-scale` set to 6.0. ```html Simple page showing random text - +

@@ -96,13 +96,13 @@ This viewport `meta` element does not prevent user scaling because it has `user- #### Passed Example 3 -This viewport `meta` element allows users to scale content up to 600% because it has `maximum-scale` set to 6.0. +This viewport `meta` element does not prevent user scaling because it has `maximum-scale` set to -1 which results in this value being dropped. ```html Simple page showing random text - +

@@ -112,15 +112,17 @@ This viewport `meta` element allows users to scale content up to 600% because it ``` -#### Passed Example 4 +### Failed + +#### Failed Example 1 -This viewport `meta` element does not prevent user scaling because it does not specify the `maximum-scale` and `user-scalable` values. +This viewport `meta` element prevents user scaling because it has `user-scalable` set to `no`. ```html Simple page showing random text - +

@@ -130,15 +132,15 @@ This viewport `meta` element does not prevent user scaling because it does not s ``` -#### Passed Example 5 +#### Failed Example 2 -This viewport `meta` element does not prevent user scaling because it has `maximum-scale` set to -1 which results in this value being dropped. +This viewport `meta` element prevents users to scale content up to 200% because it has `maximum-scale` set to 1.5. ```html Simple page showing random text - +

@@ -148,17 +150,15 @@ This viewport `meta` element does not prevent user scaling because it has `maxim ``` -### Failed - -#### Failed Example 1 +#### Failed Example 3 -This viewport `meta` element prevents user scaling because it has `user-scalable` set to `no`. +This viewport `meta` element prevents users to scale content up to 200% because it has `maximum-scale` set to 1.0. ```html Simple page showing random text - +

@@ -168,15 +168,15 @@ This viewport `meta` element prevents user scaling because it has `user-scalable ``` -#### Failed Example 2 +#### Failed Example 4 -This viewport `meta` element prevents users to scale content up to 200% because it has `maximum-scale` set to 1.5. +This viewport `meta` element prevents users to scale content up to 200% because it has `maximum-scale` set to `yes` which translates to 1.0. ```html Simple page showing random text - +

@@ -186,15 +186,17 @@ This viewport `meta` element prevents users to scale content up to 200% because ``` -#### Failed Example 3 +### Inapplicable -This viewport `meta` element prevents users to scale content up to 200% because it has `maximum-scale` set to 1.0. +#### Inapplicable Example 1 + +There is no viewport `meta` element. ```html - Simple page showing random text - + Lorem ipsum +

@@ -204,15 +206,15 @@ This viewport `meta` element prevents users to scale content up to 200% because ``` -#### Failed Example 4 +#### Inapplicable Example 2 -This viewport `meta` element prevents users to scale content up to 200% because it has `maximum-scale` set to `yes` which translates to 1.0. +This viewport `meta` element does not have a `content` attribute. ```html Simple page showing random text - +

@@ -222,17 +224,15 @@ This viewport `meta` element prevents users to scale content up to 200% because ``` -### Inapplicable - -#### Inapplicable Example 1 +#### Inapplicable Example 3 -There is no viewport `meta` element. +This viewport `meta` element does not prevent user scaling because it does not specify the `maximum-scale` nor `user-scalable` values. ```html - Lorem ipsum - + Simple page showing random text +

@@ -242,15 +242,15 @@ There is no viewport `meta` element. ``` -#### Inapplicable Example 2 +#### Inapplicable Example 4 -This viewport `meta` element does not have a `content` attribute. +This viewport `meta` element does not prevent user scaling because it does not specify the `maximum-scale` nor `user-scalable` values. ```html Simple page showing random text - +

From 5c6a5e680207d4f30bd3003d8c01838cf1418dec Mon Sep 17 00:00:00 2001 From: Tom Brunet Date: Thu, 28 Apr 2022 08:23:55 -0500 Subject: [PATCH 2/5] Change scale from 600% to 200% for Pass 2 Co-authored-by: Wilco Fiers --- _rules/meta-viewport-b4f0c3.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_rules/meta-viewport-b4f0c3.md b/_rules/meta-viewport-b4f0c3.md index 4beda9fa31a..4ec841426bd 100755 --- a/_rules/meta-viewport-b4f0c3.md +++ b/_rules/meta-viewport-b4f0c3.md @@ -78,7 +78,7 @@ This viewport `meta` element does not prevent user scaling because it has `user- #### Passed Example 2 -This viewport `meta` element allows users to scale content up to 600% because it has `maximum-scale` set to 6.0. +This viewport `meta` element allows users to scale content up to 200% because it has `maximum-scale` set to 6.0. ```html From 64f6a593b3dad1c81abd1e0bad6d169c2759410b Mon Sep 17 00:00:00 2001 From: Tom Brunet Date: Wed, 25 May 2022 21:47:34 -0500 Subject: [PATCH 3/5] Rephrase applicability --- _rules/meta-viewport-b4f0c3.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_rules/meta-viewport-b4f0c3.md b/_rules/meta-viewport-b4f0c3.md index 51ca6c48f7c..15c5ae8f31e 100755 --- a/_rules/meta-viewport-b4f0c3.md +++ b/_rules/meta-viewport-b4f0c3.md @@ -22,11 +22,11 @@ acknowledgments: ## Applicability -This rule applies to each `content` attribute on a `meta` element with a `name` [attribute value][] of `viewport`. In addition, when the `content` attribute value is mapped to a list of property/value pairs in a user-agent specific manner, one of the properties is either `user-scalable` or `maximum-scale`. +This rule applies to each `content` attribute on a `meta` element with a `name` [attribute value][] of `viewport`. In addition, the `content` [attribute value][] has the `user-scalable` or `maximum-scale` properties. ## Expectation 1 -For each test target, the [attribute value][] does hot have a `user-scalable` property with a value of `no`. +For each test target, the [attribute value][] does not have a `user-scalable` property with a value of `no`. ## Expectation 2 From 1d3d37768e6678e65ed509ff01f82e1a057722d7 Mon Sep 17 00:00:00 2001 From: Tom Brunet Date: Wed, 1 Jun 2022 21:47:12 -0500 Subject: [PATCH 4/5] Apply suggestions from code review Co-authored-by: Carlos Duarte --- _rules/meta-viewport-b4f0c3.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/_rules/meta-viewport-b4f0c3.md b/_rules/meta-viewport-b4f0c3.md index 15c5ae8f31e..563f336a2ed 100755 --- a/_rules/meta-viewport-b4f0c3.md +++ b/_rules/meta-viewport-b4f0c3.md @@ -22,7 +22,9 @@ acknowledgments: ## Applicability -This rule applies to each `content` attribute on a `meta` element with a `name` [attribute value][] of `viewport`. In addition, the `content` [attribute value][] has the `user-scalable` or `maximum-scale` properties. +This rule applies to each `content` attribute on a `meta` element with a `name` [attribute value][] of `viewport` for which at least one of the following is true: +- the `content` [attribute value][] has the `user-scalable` property; or +- the `content` [attribute value][] has the `maximum-scale` property. ## Expectation 1 @@ -227,7 +229,7 @@ This viewport `meta` element does not have a `content` attribute. #### Inapplicable Example 3 -This viewport `meta` element does not prevent user scaling because it does not specify the `maximum-scale` nor `user-scalable` values. +This viewport `meta` element does not specify the `maximum-scale` nor `user-scalable` values. ```html From 15db6de397661d2c3dda03ecebb4f8336b6b8428 Mon Sep 17 00:00:00 2001 From: Tom Brunet Date: Fri, 3 Jun 2022 08:32:02 -0500 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: Wilco Fiers --- _rules/meta-viewport-b4f0c3.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/_rules/meta-viewport-b4f0c3.md b/_rules/meta-viewport-b4f0c3.md index d5fffda61a0..38cabbbfdad 100755 --- a/_rules/meta-viewport-b4f0c3.md +++ b/_rules/meta-viewport-b4f0c3.md @@ -23,6 +23,7 @@ acknowledgments: ## Applicability This rule applies to each `content` attribute on a `meta` element with a `name` [attribute value][] of `viewport` for which at least one of the following is true: + - the `content` [attribute value][] has the `user-scalable` property; or - the `content` [attribute value][] has the `maximum-scale` property. @@ -81,13 +82,13 @@ This viewport `meta` element does not prevent user scaling because it has `user- #### Passed Example 2 -This viewport `meta` element allows users to scale content up to 200% because it has `maximum-scale` set to 6.0. +This viewport `meta` element allows users to scale content up to 200% because it has `maximum-scale` set to 2.0. ```html Simple page showing random text - +