Repository navigation
New rule: Video or audio has no auto-play audio (80f0bf, 4c31df, aaa1bf) - #416
Merged
Merged
Conversation
annethyme
added
Rule
annethyme
requested review from
Brynanders,
DagfinnRomen,
ShadowBB,
carlosapaduarte and
dd8
January 30, 2019 20:43
Collaborator
Author
|
Learn from this old issue: #40 |
danistr
reviewed
Feb 12, 2019
This comment has been minimized.
This comment has been minimized.
carlosapaduarte
approved these changes
Feb 21, 2019
carlosapaduarte
left a comment
carlosapaduarte
left a comment
Member
There was a problem hiding this comment.
Idea approved. I've left a couple of comments.
WilcoFiers
previously requested changes
Mar 3, 2019
WilcoFiers
previously requested changes
Aug 22, 2019
| The `audio` element does not autoplay. | ||
|
|
||
| ``` html | ||
| <audio src="../test-assets/moon-audio/moon-speech.mp3" controls></audio> |
Member
There was a problem hiding this comment.
Can you run prettier on this PR please.
Collaborator
There was a problem hiding this comment.
@JKODU give me a shout when this is done. Thanks for helping me out!!
carlosapaduarte
left a comment
carlosapaduarte
left a comment
Member
There was a problem hiding this comment.
Wilco's requests needs addressing. Looks good otherwise.
Added script reference for https://github.com/act-rules/act-rules.github.io/blob/a663d2df70c3ac2d71d47072de9f8d8a05bdbe61/assets/js/no-autoplay.js to custom controls test cases
Added script reference to Passed 5
WilcoFiers
removed
the
Review call 2 weeks
Updated applicability as per @WilcoFiers change request.
Updated applicability as per @WilcoFiers change request
Updated applicability as per change request https://github.com/act-rules/act-rules.github.io/pull/416/files#r316646068
Brynanders
added
the
Review call 2 weeks
Contributor
|
@Brynanders I have updated the test case (missing js file) and also formatted using prettier. |
WilcoFiers
previously requested changes
Sep 24, 2019
kasperisager
suggested changes
Oct 1, 2019
kasperisager
previously requested changes
Oct 1, 2019
Implemented @kasperisager change requests.
Spelling correction.
kasperisager
approved these changes
Oct 1, 2019
Contributor
|
Final call as per email says Oct 4th. Please verify and merge if true. |
Collaborator
|
Final Call is finished. Merging 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for approval of concept for rule in first round.
Replaces outdated rule: https://github.com/auto-wcag/auto-wcag/blob/master/_rules/outdated/SC1-4-2-audio-control-audio.md
How to Review And Approve