Skip to content

Conversation

@jeeyyy
Copy link
Collaborator

@jeeyyy jeeyyy commented Jul 23, 2019

  • show rule that do not have accessibility mapping requirements (eg: ARIA attribute is valid)

Closes issue(s):


Pull Request Etiquette

When creating PR:

  • Make sure you requesting to pull a branch (right side) to the develop branch (left side).

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

@Jym77
Copy link
Collaborator

Jym77 commented Jul 23, 2019

It this closing #697 ?

@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Jul 24, 2019

Note: This change will list all rules that do not have accessibility_requirements and this includes atomic rules used in composite rules. This needs to be discussed on a call, to make a decision if it is worth listing atomic rules in the rules page.

Various options:

  • show all rules (atomic, composite, rules that do not have accessibility_requirements)
  • show all rules, except atomic rules
  • may be we can have filtering on the page instead?

@jeeyyy
Copy link
Collaborator Author

jeeyyy commented Jul 25, 2019

Add filtering to the page, iteratively (start simple)

Perhaps fields that can be in the filtering:

  • name/ keyword/ terms
  • id
  • accessibility requirements
  • number of implementations
  • success criteria
  • input rules
  • rule type

@jeeyyy jeeyyy merged commit 94f5d3b into develop Jul 25, 2019
@jeeyyy jeeyyy deleted the allow-rule-without-acc-mapping branch July 25, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants