Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Fix --output-file breakage from grcov v0.5.14 #71

Merged
merged 3 commits into from May 12, 2020

Conversation

rye
Copy link
Contributor

@rye rye commented May 11, 2020

Closes #70.

Now, scan for both output-file and output-path; treat them the same, but for output-file print a deprecation warning. Also, update the command-line argument passed to grcov, and the documentation.

Is a deprecation notice needed? Also, should I include the updated dist/index.js file?

rye added 3 commits May 11, 2020 18:22
This change is necessary to fix the problems mentioned in actions-rs#70.

In short, `--output-file` was renamed to `--output-path` with no
backwards compatibility mechanism.  The semantics are the same.  See
also [1].

[1]: mozilla/grcov@26acaa0

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Also, update the relevant information in the README.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
If `output-path` is not recognized, but `output-file` is, then assume
that the user has not upgraded their configuration to the new option.
Print a friendly warning, but continue as before.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye rye force-pushed the grcov-v0.5.4-fix-output-file branch from 336bb8f to 42beb1f Compare May 12, 2020 00:48
@svartalf svartalf merged commit e047770 into actions-rs:master May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

grcov v0.5.14 broke the --output-file option
2 participants