From a3c4b0ae4e8f0ad0d71bb7c2f8d0419dc1983c95 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Wed, 16 Feb 2022 11:42:38 +0000 Subject: [PATCH 1/2] acceptance: Do recreate the controller-manager secret on every deployment We had to manually remove the secret first to update the GitHub credentials used by the controller, which was cumbersome. Note that you still need to recreate the controller pods and the gh webhook server pods to let them remount the recreated secret. --- acceptance/deploy.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/acceptance/deploy.sh b/acceptance/deploy.sh index fbee5c9d2f..a1b6d6e747 100755 --- a/acceptance/deploy.sh +++ b/acceptance/deploy.sh @@ -6,6 +6,8 @@ tpe=${ACCEPTANCE_TEST_SECRET_TYPE} VALUES_FILE=${VALUES_FILE:-$(dirname $0)/values.yaml} +kubectl delete secret controller-manager || : + if [ "${tpe}" == "token" ]; then if ! kubectl get secret controller-manager -n actions-runner-system >/dev/null; then kubectl create secret generic controller-manager \ From 2782f82f142b216f6b738997c8ef0b29ba78382b Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Wed, 16 Feb 2022 11:44:28 +0000 Subject: [PATCH 2/2] acceptance: Avoid "metadata.annotations too long" errors on applying CRDs --- acceptance/deploy.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/acceptance/deploy.sh b/acceptance/deploy.sh index a1b6d6e747..d602dea81d 100755 --- a/acceptance/deploy.sh +++ b/acceptance/deploy.sh @@ -37,7 +37,9 @@ if [ "${tool}" == "helm" ]; then --set image.repository=${NAME} \ --set image.tag=${VERSION} \ -f ${VALUES_FILE} - kubectl apply -f charts/actions-runner-controller/crds + # To prevent `CustomResourceDefinition.apiextensions.k8s.io "runners.actions.summerwind.dev" is invalid: metadata.annotations: Too long: must have at most 262144 bytes` + # errors + kubectl create -f charts/actions-runner-controller/crds || kubectl replace -f charts/actions-runner-controller/crds kubectl -n actions-runner-system wait deploy/actions-runner-controller --for condition=available --timeout 60s else kubectl apply \