Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ref for pr closed event when a pr is merged #141

Merged
merged 3 commits into from Jan 21, 2020

Conversation

@ericsciple
Copy link
Collaborator

@ericsciple ericsciple commented Jan 21, 2020

fixes #136

@@ -12757,6 +12757,11 @@ function getInputs() {
if (isWorkflowRepository) {
result.ref = github.context.ref;
result.commit = github.context.sha;
// Some events have an unqualifed ref. For example when a PR is merged (pull_request closed event),
Copy link
Collaborator Author

@ericsciple ericsciple Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andymckay is this a bug on the server? Seems like github.ref would always be qualified (e.g. refs/heads/master not master). For most events it's qualified. PR closed_event (when a PR is merged) is the only case I'm aware it's not.

I'm still planning to proceed with this fix here for resiliency, but just FYI since this seems like a bug on the server.

@ericsciple ericsciple merged commit 090d9c9 into master Jan 21, 2020
5 checks passed
@ericsciple ericsciple deleted the users/ericsciple/m165pr branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants