Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow proxy settings #144

Merged
merged 7 commits into from Jan 27, 2020
Merged

follow proxy settings #144

merged 7 commits into from Jan 27, 2020

Conversation

@ericsciple
Copy link
Collaborator

@ericsciple ericsciple commented Jan 24, 2020

fixes #139

@ericsciple ericsciple force-pushed the users/ericsciple/m165proxy branch from 76cbbf5 to d289d65 Jan 24, 2020
@ericsciple ericsciple requested a review from TingluoHuang Jan 24, 2020
__test__/configure-proxy.sh Outdated Show resolved Hide resolved
@ericsciple ericsciple force-pushed the users/ericsciple/m165proxy branch from 08257d3 to 2285ac1 Jan 24, 2020
@@ -99,3 +99,42 @@ jobs:
path: basic
- name: Verify basic
run: __test__/verify-basic.sh --archive

test-proxy:
Copy link
Collaborator Author

@ericsciple ericsciple Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TingluoHuang i played a bit more with your idea. i think you will like this :)

src/git-source-provider.ts Outdated Show resolved Hide resolved
@actions actions deleted a comment from i5golfzaa Jan 24, 2020
repositoryPath,
false
)
// Remove proxy and extraheader

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Remove proxy and extraheader
// Remove proxy and extraheader

@ericsciple ericsciple merged commit f90c7b3 into master Jan 27, 2020
6 checks passed
@ericsciple ericsciple deleted the users/ericsciple/m165proxy branch Jan 27, 2020
@actions actions deleted a comment from i5golfzaa Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants