Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment failed to report final status (GHES) #152

Closed
daibrahi opened this issue Apr 3, 2023 · 9 comments
Closed

Deployment failed to report final status (GHES) #152

daibrahi opened this issue Apr 3, 2023 · 9 comments
Assignees
Labels
GHES Specific to GitHub Enterprise Server

Comments

@daibrahi
Copy link

daibrahi commented Apr 3, 2023

Hello Everyone,
I have seen similar issue which has been closed, however the issue still persists. We are using GHES and lately we started facing issues when we try to deploy to github pages.
I have read the related issue and tried changing the versions to 1,1.2.6,1.2.8 but the following error was displayed

image

@yoannchaudet
Copy link
Collaborator

Can you confirm GitHub Pages is enabled for the repository?

@daibrahi
Copy link
Author

daibrahi commented Apr 4, 2023

@yoannchaudet thanks for your reply.
yes github pages is enabled for the repository and i have noticed the action fails in the following method

async function getPagesDeploymentStatus({ githubToken, deploymentId }) {
  const octokit = github.getOctokit(githubToken)
  core.info('Getting Pages deployment status...')
  try {
    const response = await octokit.request('GET /repos/{owner}/{repo}/pages/deployment/status/{deploymentId}', {
      owner: github.context.repo.owner,
      repo: github.context.repo.repo,
      deploymentId
    })

    return response.data
  } catch (error) {
    core.error('Getting Pages deployment status failed', error)
    throw error
  }
}

I assume the rest endpoint being called here is incorrect. See the docs for GHES v3.8 GitHub Pages deployment

@SirensOfTitan
Copy link

Also seeing this for GHES 3.8

@daibrahi
Copy link
Author

I have tried using postman to call the following endpoint
/repos/{owner}/{repo}/pages/deployment/status/{deploymentId}
and i get the following response.

  {
      "status": "deployment_lost"
  }

The deployment creation works fine but somehow the pipeline fails to fetch the deployment status

@GuBee33
Copy link

GuBee33 commented May 5, 2023

I have the same issue with GitHub Enterprise Server 3.7.8
how could this be solved? Any suggestion?

@jtietema
Copy link

jtietema commented May 5, 2023

I wonder if this is related to #168 as we have this error with the v1 and the error mentioned in #168 with v2.
Github pages is enabled. We used v1 up until this point, but it started failing around the 23rd of March for us.

@daibrahi
Copy link
Author

daibrahi commented May 5, 2023

The issue concerns the GitHub enterprise appliance and nothing with this deploy-pages action, they are working on the fix and will soon patch with the release.
keep an eye on https://enterprise.github.com/releases/ for the next release

@daibrahi
Copy link
Author

@JamesMGreene
Copy link
Contributor

That's correct, GHES release 3.8.3 contains a bug fix for the deployment_lost scenario (which was an issue from beyond this action's boundaries).

@JamesMGreene JamesMGreene self-assigned this May 12, 2023
@JamesMGreene JamesMGreene added the GHES Specific to GitHub Enterprise Server label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GHES Specific to GitHub Enterprise Server
Projects
None yet
Development

No branches or pull requests

6 participants