Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is not shown in red color #12

Closed
bishal-pdMSFT opened this issue Jul 12, 2022 · 3 comments
Closed

Error message is not shown in red color #12

bishal-pdMSFT opened this issue Jul 12, 2022 · 3 comments
Assignees

Comments

@bishal-pdMSFT
Copy link
Contributor

Error message is not shown in red color

image

@kotewar kotewar self-assigned this Jul 12, 2022
@kotewar
Copy link
Contributor

kotewar commented Jul 12, 2022

Do we really want to show the error message in red colour? @bishal-pdMSFT

GH cli doesn't currently colour code the errors -
Screenshot 2022-07-12 at 2 23 59 PM

The other issue I had found and mentioned in the doc was, CLI doesn't print the tick mark character in Windows CMD. I can modify this issue for the red tick printing issue in Windows, if we don't want to colour code our output error messages, which also might get trickier as background colour of the terminal changes (by user preferences).

@bishal-pdMSFT
Copy link
Contributor Author

Do we really want to show the error message in red colour? @bishal-pdMSFT

GH cli doesn't currently colour code the errors

Yeah we should maintain consistency with rest of CLI.

The other issue I had found and mentioned in the doc was, CLI doesn't print the tick mark character in Windows CMD. I can modify this issue for the red tick printing issue in Windows

Here also we should maintain consistency with core CLI. If possible we should work with CLI and contribute to fix this issue there first if it meets their triage bar.

@kotewar
Copy link
Contributor

kotewar commented Jul 13, 2022

I've dropped a message in cli slack channel regarding the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants