Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plugin dependencies #216

Merged
merged 3 commits into from Jan 6, 2022

Conversation

PeterNitscheMI
Copy link
Contributor

@PeterNitscheMI PeterNitscheMI commented Nov 19, 2021

Some REST API functions are missing which are described in the octakit documentation (https://octokit.github.io/rest.js/v18/). I need the github.rest.check.rerequestRun in my workflow.

Thus, I have updated the plugin dependencies to the latest version.

@PeterNitscheMI PeterNitscheMI requested a review from as a code owner Nov 19, 2021
@PeterNitscheMI
Copy link
Contributor Author

@PeterNitscheMI PeterNitscheMI commented Nov 23, 2021

Hey @joshmgross :-) Can you help me to bring this change on the road? We are currently blocked by the missing API. Thanks :-)

@antdking
Copy link

@antdking antdking commented Nov 26, 2021

Hey @joshmgross :-) Can you help me to bring this change on the road? We are currently blocked by the missing API. Thanks :-)

A temporary workaround you can do is to use the .request method.

Example Usage

Reference for how to use:
https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/dfc6f585ded8ca5a7bf747bf03a6b62edec40559/src/generated/endpoints.ts#L335

@joshmgross
Copy link
Member

@joshmgross joshmgross commented Dec 1, 2021

👋 Hey @PeterNitscheMI,

It looks like some licenses are out of date after this change https://github.com/actions/github-script/runs/4385889733?check_suite_focus=true

These are managed via the licensed tool - https://github.com/github/licensed

Let me know if you need help getting those updated.

@PeterNitscheMI
Copy link
Contributor Author

@PeterNitscheMI PeterNitscheMI commented Dec 30, 2021

Hey @joshmgross ,

sorry for letting you wait so long.
I have updated the license cache using the licensed cache command of licensed version 2.12.2.
A lot of licenses have been removed and I'm not sure if that is correct.
At least licensed status doesn't return any errors now.

Have a good New Year!

Peter

@joshmgross
Copy link
Member

@joshmgross joshmgross commented Jan 6, 2022

Thanks @PeterNitscheMI!

I have updated the license cache using the licensed cache command of licensed version 2.12.2.
A lot of licenses have been removed and I'm not sure if that is correct.
At least licensed status doesn't return any errors now.

Might be a version difference with licensed 🤔. CI is passing, so it's good for now. I'll update licenses separately from this PR.

@joshmgross joshmgross merged commit faea5b2 into actions:main Jan 6, 2022
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants