[windows] Change packer templates from json to hcl (#8999)

Author: shamil-mubarakshin

docs/create-image-and-azure-resources.md

@@ -217,7 +217,7 @@ Where:
 - `InstallPassword` - password for the user used to install software (Windows only);
 - `Location` - location where resources will be created (e.g., "East US");
 - `ImageName` and `ImageResourceGroupName` - name of the resource group where the managed image will be stored;
-- `TemplatePath` - path to the Packer template file (e.g., "images/windows/templates/windows-2022.json").
+- `TemplatePath` - path to the Packer template file (e.g., "images/windows/templates/windows-2022.pkr.hcl").
 
 ### Required variables
 

helpers/GenerateResourcesAndImage.ps1

@@ -19,10 +19,10 @@ Function Get-PackerTemplatePath {
     switch ($ImageType) {
         # Note: Double Join-Path is required to support PowerShell 5.1
         ([ImageType]::Windows2019) {
-            $relativeTemplatePath = Join-Path (Join-Path "windows" "templates") "windows-2019.json"
+            $relativeTemplatePath = Join-Path (Join-Path "windows" "templates") "windows-2019.pkr.hcl"
         }
         ([ImageType]::Windows2022) {
-            $relativeTemplatePath = Join-Path (Join-Path "windows" "templates") "windows-2022.json"
+            $relativeTemplatePath = Join-Path (Join-Path "windows" "templates") "windows-2022.pkr.hcl"
         }
         ([ImageType]::Ubuntu2004) {
             $relativeTemplatePath = Join-Path (Join-Path "ubuntu" "templates") "ubuntu-20.04.json"
@@ -155,7 +155,7 @@ Function GenerateResourcesAndImage {
     if ($Force -and $ReuseResourceGroup) {
         throw "Force and ReuseResourceGroup cannot be used together."
     }
-    
+
     Show-LatestCommit -ErrorAction SilentlyContinue
 
     # Validate packer is installed
@@ -229,6 +229,13 @@ Function GenerateResourcesAndImage {
 
     $InstallPassword = $env:UserName + [System.GUID]::NewGuid().ToString().ToUpper()
 
+    Write-Host "Downloading packer plugins..."
+    & $PackerBinary init $TemplatePath
+
+    if ($LastExitCode -ne 0) {
+        throw "Packer plugins download failed."
+    }
+
     Write-Host "Validating packer template..."
     & $PackerBinary validate `
         "-var=client_id=fake" `
@@ -242,7 +249,7 @@ Function GenerateResourcesAndImage {
         "-var=allowed_inbound_ip_addresses=$($AllowedInboundIpAddresses)" `
         "-var=azure_tags=$($TagsJson)" `
         $TemplatePath
-    
+
     if ($LastExitCode -ne 0) {
         throw "Packer template validation failed."
     }
@@ -290,7 +297,7 @@ Function GenerateResourcesAndImage {
                     # Resource group already exists, ask the user what to do
                     $title = "Resource group '$ResourceGroupName' already exists"
                     $message = "Do you want to delete the resource group and all resources in it?"
-                
+
                     $options = @(
                         [System.Management.Automation.Host.ChoiceDescription]::new("&Yes", "Delete the resource group and all resources in it."),
                         [System.Management.Automation.Host.ChoiceDescription]::new("&No", "Keep the resource group and continue."),
@@ -346,7 +353,7 @@ Function GenerateResourcesAndImage {
             if ($LastExitCode -ne 0) {
                 throw "Failed to create service principal '$ServicePrincipalName'."
             }
-            
+
             $ServicePrincipalAppId = $ServicePrincipal.appId
             $ServicePrincipalPassword = $ServicePrincipal.password
             $TenantId = $ServicePrincipal.tenant
@@ -383,7 +390,7 @@ Function GenerateResourcesAndImage {
         Write-Error $_
     } finally {
         Write-Verbose "`nCleaning up..."
-        
+
         # Remove ADServicePrincipal and ADApplication
         if ($ADCleanupRequired) {
             Write-Host "Removing ADServicePrincipal..."

images.CI/linux-and-win/azure-pipelines/windows2019.yml

@@ -18,4 +18,4 @@ jobs:
   parameters:
     image_type: windows2019
     image_readme_name: Windows2019-Readme.md
-    image_template_name: windows-2019.json
+    image_template_name: windows-2019.pkr.hcl

images.CI/linux-and-win/azure-pipelines/windows2022.yml

@@ -18,4 +18,4 @@ jobs:
   parameters:
     image_type: windows2022
     image_readme_name: Windows2022-Readme.md
-    image_template_name: windows-2022.json
+    image_template_name: windows-2022.pkr.hcl

images.CI/linux-and-win/build-image.ps1

@@ -22,8 +22,6 @@ if (-not (Test-Path $TemplatePath))
 $ImageTemplateName = [io.path]::GetFileName($TemplatePath).Split(".")[0]
 $InstallPassword = [System.GUID]::NewGuid().ToString().ToUpper()
 
-packer validate -syntax-only $TemplatePath
-
 $SensitiveData = @(
     'OSType',
     'StorageAccountLocation',
@@ -37,6 +35,12 @@ $SensitiveData = @(
 Write-Host "Show Packer Version"
 packer --version
 
+Write-Host "Download packer plugins"
+packer init $TemplatePath
+
+Write-Host "Validate packer template"
+packer validate -syntax-only $TemplatePath
+
 Write-Host "Build $ImageTemplateName VM"
 packer build    -var "client_id=$ClientId" `
                 -var "client_secret=$ClientSecret" `