C++ / MSBuild not using latest toolset

[marc2k3]

Description

VS 2022 17.5 should be using the latest 14.35 toolset but it's not.

Platforms affected

• Azure DevOps
• GitHub Actions - Standard Runners
• GitHub Actions - Larger Runners

Runner images affected

• Ubuntu 20.04
• Ubuntu 22.04
• macOS 11
• macOS 12
• Windows Server 2019
• Windows Server 2022

Image version and build link

Image: windows-2022
Version: 20230417.1
Included Software: https://github.com/actions/runner-images/blob/win22/20230417.1/images/win/Windows2022-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20230417.1

Is it regression?

No

Expected behavior

Expecting the latest 14.35 toolset to be used.

Actual behavior

14.34 toolset is being used as can be seen here...

https://github.com/marc2k3/foo_musicbrainz64/actions/runs/4796230044/jobs/8531766018#step:6:562

Repro steps

This causes the build to error here...

https://github.com/marc2k3/foo_musicbrainz64/actions/runs/4796230044/jobs/8531766018#step:6:570

2>D:\a\foo_musicbrainz64\foo_musicbrainz64\src\ReleaseParser.cpp(268,50):
error C2039: 'fold_left': is not a member of 'std::ranges' [D:\a\foo_musicbrainz64\foo_musicbrainz64\src\foo_musicbrainz64.vcxproj]

I'm using /std:c++latest expecting the latest std::ranges toys like fold_left, zip_view etc to work.

[ilia-shipitsin]

Hello @marc2k3 , I'll have a look

[ilia-shipitsin]

so far, 14.35.32215 is shipped with image (I wonder why latest didn't pick it). let us figure out...

[ilia-shipitsin]

using the following snippet

    - name: 'list vc tools'
      run: |
        get-childitem -Path 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC'
        get-content 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\Microsoft.VCToolsVersion.v143.default.props'

it turns out that 14.34.31931 is used for v143 (I'll try to figure out why)

[marc2k3]

Thanks for looking in to this. I was able to override the VCToolsVersion in my .vcxproj and the build now succeeds...

https://github.com/marc2k3/foo_musicbrainz64/commit/5ac296551a3d270f6f93561a93c84b8e42288eb8

diff --git a/src/foo_musicbrainz64.vcxproj b/src/foo_musicbrainz64.vcxproj
index 4d4755a..925f188 100644
--- a/src/foo_musicbrainz64.vcxproj
+++ b/src/foo_musicbrainz64.vcxproj
@@ -23,6 +23,7 @@
     <UseDebugLibraries>true</UseDebugLibraries>
     <PlatformToolset>v143</PlatformToolset>
     <CharacterSet>Unicode</CharacterSet>
+    <VCToolsVersion>14.35.32215</VCToolsVersion>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'" Label="Configuration">
     <ConfigurationType>DynamicLibrary</ConfigurationType>
@@ -30,6 +31,7 @@
     <PlatformToolset>v143</PlatformToolset>
     <WholeProgramOptimization>true</WholeProgramOptimization>
     <CharacterSet>Unicode</CharacterSet>
+    <VCToolsVersion>14.35.32215</VCToolsVersion>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
   <ImportGroup Label="ExtensionSettings" />

Successful build: https://github.com/marc2k3/foo_musicbrainz64/actions/runs/4801242199

[ilia-shipitsin]

I've found that we install several VS workloads, couple of them are v143, namely Microsoft.VisualStudio.Component.VC.14.34.17.4.x86.x64 and Microsoft.VisualStudio.Component.VC.Tools.x86.x64, thus we do not control which one of them actually wins.

we'll address it in some way. thanks for finding!

[ilia-shipitsin]

as a side note, /std:c++latest does not specify the latest toolset available (for example, you may specify v141), it means "use all experimental features in chosen toolset" :)

[marc2k3]

Using Microsoft.VisualStudio.Component.VC.Tools.x86.x64 as a search term is not found in the toolset-2022.json you linked to.

If you search for just Microsoft.VisualStudio.Component.VC.Tools, you get this without the x86.x64.