[windows 22 & 25 ] Upgrade visual studio version to 17.14 #12363
Conversation
|
.Description .Related issue Julio Cesar Sandoval |
kishorekumar-anchala
added
CI windows-2022
CI windows-2025
and removed
CI windows-2022
CI windows-2025
labels
|
Why is this a draft? I believe a few bugs were introduced in 17.13 that were fixed in 17.14. I've got code that will build with 17.14 (locally) that will not build using 17.13. I know there are others with the same issue. 17.14 was released on 13-May, 17.14.5 was released 10-June. |
kishorekumar-anchala
added
CI windows-2022
CI windows-2025
and removed
CI windows-2022
CI windows-2025
labels
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Visual Studio installer channel identifiers to use the new 17.14 release for Windows 2022 and 2025 images.
- Updated
installChannelvalues to point at the VS 17.14 installer in both toolset files.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| images/windows/toolsets/toolset-2025.json | Bumped installChannel ID for VS 17.14 Enterprise |
| images/windows/toolsets/toolset-2022.json | Bumped installChannel ID for VS 17.14 Enterprise |
Comments suppressed due to low confidence (2)
images/windows/toolsets/toolset-2025.json:140
- Please verify that the existing
signaturehashes still match the VS 17.14 installer. If the installer binary changed, update these certificate fingerprints accordingly.
"installChannel": "624045707_-738089513",
images/windows/toolsets/toolset-2022.json:158
- Please verify that the existing
signaturehashes still match the VS 17.14 installer. If the installer binary changed, update these certificate fingerprints accordingly.
"installChannel": "624045707_-738089513",
|
@kishorekumar-anchala, it seems there were no documentation updates at all. runner-images/images/windows/Windows2022-Readme.md Lines 225 to 237 in 938abb9 etc. still shows 17.13, even though images with 17.14 have started to be rolled out. |
GitHub updated Visual Studio to 17.14 for the windows-2022 runner image (actions/runner-images#12363). The STL shipped with it expects clang 19 or newer. => Remove clang 18, add clang 20, keep clang 19.
* add opencv android * Update xmake.lua * fix missing includedirs and some libs to link * remove lib prefix from filename of libs to link * add missing linkdirs * switch linkdirs to libs for shared build Co-authored-by: Saikari <lin@sz.cn.eu.org> * remove unused local arch variable * handle shared libraries * remove useless package:addenv for android * refactor add links * clean useless second for loop * Try fix Windows arm64 build * Update xmake.lua * fixup * retry * set BUILD_ANDROID_PROJECTS to OFF by default for android * win@arm64 vs sdkver required is gt `10.0.26100` * Update xmake.lua * Update xmake.lua * Update xmake.lua * Update xmake.lua * check `os.trymv` * test DCPU_BASELINE=NEON for windows arm * Revert "test DCPU_BASELINE=NEON for windows arm" This reverts commit b401926. * Try to dump variables during Windows OS /MT Runtime Build * re-check * Try again, since MSVC maybe fixed existing toolchain bug * Update xmake.lua * trigger ci * Retry since actions/runner-images#12363 is merged * Retry assuming it releaased newest Windows SDK actions/runner-images#12316 * tackle Github CI Worker again to validate Windows-2022/2025 workers are unable to build OpenCV ARM opencv/opencv#27401 actions/runner-images#12316 * Tackle Github CI once again as actions/runner-images#12506 (comment) --------- Co-authored-by: Clement Devevey <68287089+Clement-Devevey@users.noreply.github.com> Co-authored-by: Saikari <lin@sz.cn.eu.org>
Description
This PR will upgrade the Visual Studio version to 17.14 for Windows 22 and 25.
Related issue:
#12274
#12287
Check list