[windows] warmup Azure CLI #8427
Conversation
Improve Azure CLI first run timing. Follow up: actions#8294 Co-authored-by: Jesse Houwing <jesse.houwing@gmail.com>
|
Replaces the part of this pull request that performs the redirection of the |
| az --help | ||
| if ($LASTEXITCODE -ne 0) | ||
| { | ||
| throw "Command 'az --help' failed" | ||
| } |
There was a problem hiding this comment.
Don't we have tests that do the same?
There was a problem hiding this comment.
even if we do, it would be a leaked abstraction.
tests do testing, warmup does warmup
There was a problem hiding this comment.
Current test does az --version. Which is nice too, as it causes the caching of the version information on disk (as az --version does an update check and caches the result).
There was a problem hiding this comment.
someone once may want to change tests behavior. I would not like to depend on those changes, thus dedicated warm up makes sense (even if it's identical)
There was a problem hiding this comment.
Ok. I would only hide az's output then and put braces according to 1TBS rule.
There was a problem hiding this comment.
I used VS Code with whatever we have in .vscode, I wonder why do you think code is not compliant
|
/azp run windows2019,windows2022 |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run windows2019,windows2022 |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Description
warmup Azure CLI during image generation to improve first run timing
Related issue:
#8296
Check list