Skip to content

Conversation

miketimofeev
Copy link
Contributor

@miketimofeev miketimofeev commented May 14, 2020

Description

Adding Ubuntu20 generation to CI

Related issue:

N\A

Check list

  • [N\A] Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Comment on lines 18 to 48
apt-fast install -y --no-install-recommends \
php7.1 \
php7.1-bcmath \
php7.1-bz2 \
php7.1-cgi \
php7.1-cli \
php7.1-common \
php7.1-curl \
php7.1-dba \
php7.1-dev \
php7.1-enchant \
php7.1-fpm \
php7.1-gd \
php7.1-gmp \
php7.1-imap \
php7.1-interbase \
php7.1-intl \
php7.1-json \
php7.1-ldap \
php7.1-mbstring \
php7.1-mcrypt \
php7.1-mysql \
php7.1-odbc \
php7.1-opcache \
php7.1-pgsql \
php7.1-phpdbg \
php7.1-pspell \
php7.1-readline \
php7.1-recode \
php7.1-snmp \
php7.1-soap \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should start with only 7.4.
7.2 is out of support, and 7.3 will be supported until December. If we need to add one later I prefer that than building dependency on the older version unnecessarily:

https://www.php.net/supported-versions.php


set -e

DEFAULT_JDK_VERSION=8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think we should set 11 as default. @brunoborges would probably like that too. And it's a good preamble to switch it in 18.04 later.

@miketimofeev
Copy link
Contributor Author

This is awesome. One minor tweak to consider is to remove Java 12.

There is a new Java version every 6 months, so, if it is not a big deal for your team to keep up, then just keep the latest non-LTS pre installed (today, that's 14). Otherwise, just keep the LTS ones pre installed.

I believe that users who want a non-LTS version like 12, 13 or 14, should be fine having to install manually.

We can do that in the scope of migration to Adopt Open JDK.
@alepauly thoughts?

@AlenaSviridenko AlenaSviridenko merged commit 021e7bc into actions:master May 26, 2020
@miketimofeev miketimofeev deleted the v-mitim/add_ubuntu_20_to_ci branch June 1, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.