Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extractor selection on windows #141

Merged

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Aug 19, 2021

On Windows the extractor uses tar instead of zip because the code is using os.arch() (which returns the arch like x64 or arm64) instead of os.platform().
This PR fixes this problem.

@paulcacheux paulcacheux force-pushed the fix-windows-extractor-selection branch from e11891a to bba6fe1 Compare Aug 19, 2021
@paulcacheux paulcacheux marked this pull request as ready for review Aug 19, 2021
@paulcacheux paulcacheux requested a review from Aug 19, 2021
@paulcacheux
Copy link
Contributor Author

@paulcacheux paulcacheux commented Aug 22, 2021

Here is a demo repo to demonstrate the problem: https://github.com/paulcacheux/poc-setup-go-demo

@paulcacheux
Copy link
Contributor Author

@paulcacheux paulcacheux commented Aug 23, 2021

Friendly ping, maybe @joshmgross
Is this repo still maintained ? It seems to be infected with bots..

@joshmgross
Copy link
Member

@joshmgross joshmgross commented Aug 23, 2021

👋 Hey @paulcacheux, thanks for the ping. I'll find a team to review and release this bug fix.

@joshmgross joshmgross closed this Aug 23, 2021
@joshmgross joshmgross reopened this Aug 23, 2021
@paulcacheux
Copy link
Contributor Author

@paulcacheux paulcacheux commented Aug 23, 2021

The job that is failing seems to be unrelated to the changes. To fix it I think another PR updating the node dependencies would be needed in my opinion. Happy to help if needed

@mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Aug 24, 2021

Hi @paulcacheux, I agree with you on

The job that is failing seems to be unrelated to the changes.

I created #144 where I fixed those issues with the developpement of a new feature

@joshmgross joshmgross merged commit 331ce1d into actions:main Aug 25, 2021
25 of 27 checks passed
@joshmgross
Copy link
Member

@joshmgross joshmgross commented Aug 25, 2021

This fix should now be available in https://github.com/actions/setup-go/releases/tag/v2.1.4, and v2 soon.

@paulcacheux
Copy link
Contributor Author

@paulcacheux paulcacheux commented Aug 25, 2021

Awesome, thank you !

@timhaines
Copy link

@timhaines timhaines commented Aug 29, 2021

Great to see this. 💯 Would have saved me 20 minutes today if it was on v2 already.

shogo82148 added a commit to reviewdog/action-golangci-lint that referenced this issue Aug 29, 2021
shogo82148 added a commit to reviewdog/action-golangci-lint that referenced this issue Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants