Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADR for integrating cache functionality to setup-go action #217

Merged

Conversation

dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 13, 2022

Prepare an ADR for support caching in setup-go.

@dmitry-shibanov dmitry-shibanov requested a review from a team as a code owner Apr 13, 2022
with:
go-version: '18'
cache: true
cache-dependency-path: **/go.sum
Copy link
Contributor

@brcrista brcrista Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you set cache-dependency-path without setting cache? Does it imply cache? I suppose there's precedent here from the other setup- actions, but just wanted to clarify here

Copy link
Contributor Author

@dmitry-shibanov dmitry-shibanov Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache-dependency-path input only works with enabled cache. The cache-dependency-path will override file from which cache is generated.

@tisba
Copy link

tisba commented Apr 14, 2022

for reference, see #130

@dmitry-shibanov dmitry-shibanov merged commit 56a61c9 into actions:main Apr 26, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants