Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for cache #238

Merged

Conversation

vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented Jun 14, 2022

Added logic to handle cache errors similarly actions/cache:
https://github.com/actions/cache/blob/main/src/restore.ts#L33

Execution of the action is not interrupted if the cache restore operation returns an error.

@vsafonkin vsafonkin requested a review from a team as a code owner Jun 14, 2022
Copy link
Contributor

@brcrista brcrista left a comment

This should probably go in the restoreCache() function from the @actions/cache toolkit package. That way everything that uses caching will handle 503s correctly.

@vsafonkin vsafonkin changed the title Error handling for cache restore Error handling for cache Jun 28, 2022
@brcrista
Copy link
Contributor

brcrista commented Jun 29, 2022

Upstream fix: actions/toolkit#1122

@vsafonkin vsafonkin requested a review from brcrista Jun 30, 2022
@vsafonkin
Copy link
Contributor Author

vsafonkin commented Jun 30, 2022

@brcrista, please review

Copy link
Contributor

@brcrista brcrista left a comment

We just have to bump @actions/cache to v3: actions/toolkit#1122

Sorry, missed the new changes

src/cache-save.ts Outdated Show resolved Hide resolved
@marko-zivic-93 marko-zivic-93 merged commit 84cbf80 into actions:main Jul 1, 2022
37 checks passed
@vsafonkin vsafonkin deleted the v-vsafonkin/cache-error-handling branch Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants