Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support go.work file for go-version-file #283

Merged

Conversation

koba1t
Copy link
Contributor

@koba1t koba1t commented Nov 1, 2022

Description:
Please add support for go.work file to the go-version-file.

Related issue:
#284

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@koba1t koba1t requested a review from a team as a code owner November 1, 2022 10:20
@koba1t koba1t force-pushed the add_support_gowork_for_go-version-file branch 2 times, most recently from 8fb6887 to ff326dc Compare November 1, 2022 11:05
@dmitry-shibanov
Copy link
Contributor

Hello @koba1t. Could you please create an issue to track it. Besides, could you please run the npm ci && npm run build command to regenerate dist?

@koba1t koba1t force-pushed the add_support_gowork_for_go-version-file branch from ff326dc to 7678c83 Compare November 1, 2022 12:25
@koba1t
Copy link
Contributor Author

koba1t commented Nov 1, 2022

could you please run the npm ci && npm run build command to regenerate dist?

Thanks, I run that command and pushed a commit.

@koba1t
Copy link
Contributor Author

koba1t commented Nov 1, 2022

Hi @dmitry-shibanov

Thanks for your advice.
I have responded to your comments.

Could you please create an issue to track it.

I create "feature request" at #284.

@marko-zivic-93 marko-zivic-93 merged commit e983b65 into actions:main Nov 8, 2022
46 checks passed
@koba1t koba1t deleted the add_support_gowork_for_go-version-file branch November 8, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants