Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe cache key format in readme #215

Merged
merged 1 commit into from Dec 29, 2021
Merged

Describe cache key format in readme #215

merged 1 commit into from Dec 29, 2021

Conversation

beatngu13
Copy link
Contributor

Description:
Several users, including myself, wondered what cache key format is being used under the hood (see e.g. here or here). This PR adds a corresponding description – based on computeCacheKey – to the README.md.

Related issue:
n/a

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

copybara-service bot pushed a commit to google/google-java-format that referenced this pull request Sep 9, 2021
As of August 30, ["`setup-java` supports caching for both Gradle and Maven projects"](https://github.blog/changelog/2021-08-30-github-actions-setup-java-now-supports-dependency-caching/). This helps to reduce the amount of boilerplate code in the workflow file.

More details can be found in the [corresponding docs](https://github.com/actions/setup-java#caching-packages-dependencies). (And if you wonder what's the used cache key format: actions/setup-java#215)

Fixes #660

COPYBARA_INTEGRATE_REVIEW=#660 from beatngu13:patch-1 47e262b
PiperOrigin-RevId: 395674252
@beatngu13
Copy link
Contributor Author

@dmitry-shibanov thank you for reviewing and approving. That was 20 days ago, is there anything else I can do get this merged?

@MaksimZhukov
Copy link
Contributor

Hello @beatngu13! Thank you for the contribution!

@MaksimZhukov MaksimZhukov merged commit 04d5353 into actions:main Dec 29, 2021
1 check passed
@beatngu13 beatngu13 deleted the update-readme-cache-key branch Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants