Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Update zeit/ncc to vercel/ncc #270

Merged
merged 6 commits into from Apr 26, 2022

Conversation

KengoTODA
Copy link
Contributor

@KengoTODA KengoTODA commented Jan 7, 2022

Reopen #190 because vercel/ncc#748 has been fixed.

Description:

zeit/ncc is no longer maintained, so it's better to replace it with vercel/ncc.

I've confirmed that this change does not affect file size so much:

  • dist/cleanup/index.js: 2694241 -> 2690020 (-4221 bytes)
  • dist/setup/index.js: 4060921 -> 4060960 (+39 bytes)

Related issue:

None

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Jan 10, 2022

Hello @KengoTODA. Thank you for your pull request. It looks good, but because it produces a lot of changes for dist directory I'd like to test it more from our side. When we test it from our side, we'll merge your pull request.
Thank you for your participation and contributions.

@KengoTODA KengoTODA requested a review from as a code owner Apr 13, 2022
@KengoTODA
Copy link
Contributor Author

@KengoTODA KengoTODA commented Apr 26, 2022

The build failed due to an unstable npm repository. Simply run the workflow run then it will pass. I've confirmed in my repo.

@dmitry-shibanov dmitry-shibanov merged commit dd80852 into actions:main Apr 26, 2022
154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants