Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBT in cache managers. #302

Merged
merged 13 commits into from Apr 20, 2022
Merged

Add SBT in cache managers. #302

merged 13 commits into from Apr 20, 2022

Conversation

fmeriaux
Copy link
Contributor

@fmeriaux fmeriaux commented Mar 24, 2022

Description:
Describe your changes.

Add SBT cache manager.

Related issue:
Add link to the related issue.

#266 (comment)

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

src/cache.ts Outdated Show resolved Hide resolved
@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 4, 2022

Hello @fmeriaux. Could you please sync with the main branch?

@fmeriaux fmeriaux requested a review from as a code owner Apr 4, 2022
@fmeriaux
Copy link
Contributor Author

@fmeriaux fmeriaux commented Apr 4, 2022

Hello @fmeriaux. Could you please sync with the main branch?

Done

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 11, 2022

Hello @fmeriaux. Could you please add e2e tests for sbt ?

@fmeriaux
Copy link
Contributor Author

@fmeriaux fmeriaux commented Apr 11, 2022

Hello @fmeriaux. Could you please add e2e tests for sbt ?

Yes, no problem, but can you detail a little more what I have to do?

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 11, 2022

Hello @fmeriaux. Could you please add e2e tests for sbt ?

Yes, no problem, but can you detail a little more what I have to do?

I think it should be something similar to Gradle test.

@fmeriaux
Copy link
Contributor Author

@fmeriaux fmeriaux commented Apr 12, 2022

Hello @fmeriaux. Could you please add e2e tests for sbt ?

Yes, no problem, but can you detail a little more what I have to do?

I think it should be something similar to Gradle test.

Thanks, done !

@Donnadam
Copy link

@Donnadam Donnadam commented Apr 12, 2022

@fmeriaux
Copy link
Contributor Author

@fmeriaux fmeriaux commented Apr 12, 2022

According to https://github.com/coursier/cache-action#path

Cache should use the default OS-dependent location.

PR is updated

src/cache.ts Show resolved Hide resolved
@dmitry-shibanov dmitry-shibanov merged commit 0ed94a5 into actions:main Apr 20, 2022
154 checks passed
@fmeriaux fmeriaux deleted the sbt-cache branch Apr 21, 2022
src/cache.ts Show resolved Hide resolved
@fmeriaux fmeriaux mentioned this pull request May 25, 2022
2 tasks
julienrf added a commit to scalacenter/website that referenced this issue Jun 28, 2022
The support of sbt caching has been implement recently in actions/setup-java#302 and actions/setup-java#332 by Florian Meriaux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants