Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for Zulu arm64 architecture #339

Merged

Conversation

ppalucha
Copy link
Contributor

@ppalucha ppalucha commented Jun 7, 2022

Description:
For Azul OpenJDK one of the supported architectures is arm64, eg.:

https://api.azul.com/zulu/download/community/v1.0/bundles/?os=linux&ext=tar.gz&bundle_type=jdk&javafx=false&arch=arm64&hw_bitness=&release_status=ga

However, value 'arm64' for architecture is not listed as available option in official API docs:

https://app.swaggerhub.com/apis-docs/azul/zulu-download-community/1.0#/bundles/get_bundles_

According to the docs, a combination of arch=arm and proper hw_bitness should be used. Also, today temporarily arm64 stopped working, giving {"arch":["Select a valid choice. arm64 is not one of the available choices."]} error.

I believe it's safer to use a supported combination of arch and hw_bitness. The same is currently done for x64 - it is translated to arch=x86&hw_bitness=64 even though x64 currently works when querying API:

https://api.azul.com/zulu/download/community/v1.0/bundles/?os=linux&ext=tar.gz&bundle_type=jdk&javafx=false&arch=x64&hw_bitness=&release_status=ga

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Azul API stopped to support arm64 architecture, the only supported
option for ARM cpus is now 'arm'. This requires to set up hw_bitness
properly to get 64 bits version. 32 bits version can be obtained by
using 'arm' as an architecture.
@ppalucha ppalucha requested a review from as a code owner Jun 7, 2022
@marko-zivic-93 marko-zivic-93 merged commit 6280813 into actions:main Jun 10, 2022
169 checks passed
@ppalucha ppalucha deleted the pp/fix-arm64-architecture branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants