Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #380

Merged
merged 3 commits into from Sep 9, 2022
Merged

Fix typo #380

merged 3 commits into from Sep 9, 2022

Conversation

qhy040404
Copy link
Contributor

@qhy040404 qhy040404 commented Sep 9, 2022

Description:
Fix typo

Related issue:
None

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@qhy040404
Copy link
Contributor Author

qhy040404 commented Sep 9, 2022

I don't know why dist/index.js generated in CI is 4142kB, but on my own computer it is 4144kB.
Maybe node.js version is different. I have node.js 17 on my computer,

@dmitry-shibanov
Copy link
Contributor

I don't know why dist/index.js generated in CI is 4142kB, but on my own computer it is 4144kB. Maybe node.js version is different. I have node.js 17 on my computer,

Hello @qhy040404. For setup-java we use the same major version as in action.yml (node16)

@qhy040404
Copy link
Contributor Author

Hello @qhy040404. For setup-java we use the same major version as in action.yml (node16)

Thanks for your reply. I just download dist file from CI, and commit them as output dist.

@dmitry-shibanov dmitry-shibanov merged commit 7bbeb80 into actions:main Sep 9, 2022
178 checks passed
@dmitry-shibanov
Copy link
Contributor

@qhy040404 Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants