Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/cache to 3.0.4 version #392

Merged
merged 9 commits into from Oct 17, 2022

Conversation

kotewar
Copy link
Contributor

@kotewar kotewar commented Oct 11, 2022

Description:
Updated actions/cache to latest version 3.0.4

Related issue:
Some bug fixes were made in the actions/cache module that are needed to be made available to the setup-java action users to utilise all the actions/cache feature.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@kotewar kotewar requested a review from a team Oct 11, 2022
@kotewar kotewar changed the title Update actions/cache to 3.0.4 (latest) version Update actions/cache to 3.0.5 (latest) version Oct 17, 2022
@kotewar kotewar changed the title Update actions/cache to 3.0.5 (latest) version Update actions/cache to 3.0.4 (latest) version Oct 17, 2022
@kotewar kotewar changed the title Update actions/cache to 3.0.4 (latest) version Update actions/cache to 3.0.4 version Oct 17, 2022
@dmitry-shibanov
Copy link
Contributor

Hello @kotewar. Thank you for your pull request. The actions/cache 3.0.5 is available. Could you please update it to the 3.0.5 version ? Besides, could you please revert changes regarding to other dependencies ?

@kotewar
Copy link
Contributor Author

kotewar commented Oct 17, 2022

Hi @dmitry-shibanov, actions/cache 3.0.5 currently has one issue that's being figured out, hence kept it v3.0.4. I'll upgrade it to 3.0.5 as soon as we have a confirmation that issue. Meanwhile let's keep this PR on hold.

Secondly, the changes to other dependencies occurred as part of the checks where the package-lock.json had to be in sync with the package.json changes, and the corresponding licenses had to be updated to pass the checks. In case I am doing it wrong, please suggest me on how it can be done correctly. I used licensed cache to update the licenses.

Also, I suspect some of the dependencies upgraded could be a result of updated dependencies of actions/cache newer versions as it internally refers to actions/core and some other dependencies.

@dmitry-shibanov
Copy link
Contributor

Thank you for your clarification. Could you please sync with main and run npm install --save @actions/cache@3.0.4 or npm update @actions/cache@3.0.4 commands because I've got the minimal update of package-lock.json. Besides, the actions/core is already to the latest version on main.

@kotewar
Copy link
Contributor Author

kotewar commented Oct 17, 2022

I can try that.

I actually updated the version of actions/cache package.json manually and ran npm install, and doing so updated the package-lock.json completely it seems.

@kotewar
Copy link
Contributor Author

kotewar commented Oct 17, 2022

I've made the necessary changes, let me know if it looks good to you (after the checks are all passed).
Let's also keep this PR on hold till we have a confirmation if we're good to upgrade it to 3.0.5.

@dmitry-shibanov
Copy link
Contributor

It looks good. Thank you!

@dmitry-shibanov dmitry-shibanov merged commit 2c53c1a into main Oct 17, 2022
178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants