Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: operating-system -> os #184

Merged
merged 1 commit into from Jan 20, 2021

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Aug 15, 2020

Schema validation was flagging the old property name

Schema validation was flagging the old property name
@bryanmacfarlane
Copy link
Member

@bryanmacfarlane bryanmacfarlane commented Jan 20, 2021

which schema validation? os isn't a well known property - the matrix leg name can be whatever we want. was it because of the hyphen?

@nschonni
Copy link
Contributor Author

@nschonni nschonni commented Jan 20, 2021

Through VS Code, but I don't really feel strongly about this, since either seems to work. I think os is just more commonly used in examples and snippets.

@bryanmacfarlane bryanmacfarlane merged commit 05f0551 into actions:main Jan 20, 2021
44 checks passed
44 checks passed
@github-actions
build (ubuntu-latest)
Details
@github-actions
test-proxy
Details
@github-actions
local-cache (ubuntu-latest, 10)
Details
@github-actions
build (windows-latest)
Details
@github-actions
local-cache (ubuntu-latest, 12)
Details
@github-actions
build (macos-latest)
Details
@github-actions
local-cache (ubuntu-latest, 14)
Details
@github-actions
local-cache (windows-latest, 10)
Details
@github-actions
local-cache (windows-latest, 12)
Details
@github-actions
local-cache (windows-latest, 14)
Details
@github-actions
local-cache (macos-latest, 10)
Details
@github-actions
local-cache (macos-latest, 12)
Details
@github-actions
local-cache (macos-latest, 14)
Details
@github-actions
test-bypass-proxy
Details
@github-actions
manifest (ubuntu-latest, 10.15)
Details
@github-actions
manifest (ubuntu-latest, 12.16.0)
Details
@github-actions
manifest (ubuntu-latest, 14.2.0)
Details
@github-actions
manifest (windows-latest, 10.15)
Details
@github-actions
manifest (windows-latest, 12.16.0)
Details
@github-actions
manifest (windows-latest, 14.2.0)
Details
@github-actions
manifest (macos-latest, 10.15)
Details
@github-actions
manifest (macos-latest, 12.16.0)
Details
@github-actions
manifest (macos-latest, 14.2.0)
Details
@github-actions
check-latest (ubuntu-latest, 10)
Details
@github-actions
check-latest (ubuntu-latest, 11)
Details
@github-actions
check-latest (ubuntu-latest, 12)
Details
@github-actions
check-latest (ubuntu-latest, 14)
Details
@github-actions
check-latest (windows-latest, 10)
Details
@github-actions
check-latest (windows-latest, 11)
Details
@github-actions
check-latest (windows-latest, 12)
Details
@github-actions
check-latest (windows-latest, 14)
Details
@github-actions
check-latest (macos-latest, 10)
Details
@github-actions
check-latest (macos-latest, 11)
Details
@github-actions
check-latest (macos-latest, 12)
Details
@github-actions
check-latest (macos-latest, 14)
Details
@github-actions
node-dist (ubuntu-latest, 11)
Details
@github-actions
node-dist (ubuntu-latest, 13)
Details
@github-actions
node-dist (windows-latest, 11)
Details
@github-actions
node-dist (windows-latest, 13)
Details
@github-actions
node-dist (macos-latest, 11)
Details
@github-actions
node-dist (macos-latest, 13)
Details
@github-actions
old-versions (ubuntu-latest)
Details
@github-actions
old-versions (windows-latest)
Details
@github-actions
old-versions (macos-latest)
Details
@bryanmacfarlane
Copy link
Member

@bryanmacfarlane bryanmacfarlane commented Jan 20, 2021

cool. merged. just wanted to understand

@nschonni nschonni deleted the nschonni:operating-system-to-os branch Jan 20, 2021
This was referenced Mar 7, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants