Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'cache-hit' as output #327

Merged
merged 1 commit into from Sep 24, 2021
Merged

Conversation

WtfJoke
Copy link
Contributor

@WtfJoke WtfJoke commented Sep 3, 2021

  • Add 'cache-hit' to outputs
  • Fixes #316

Note to maintainers: I'm not sure about the changes in module.exports they came from the formatting task afaik. If you want I can revert these lines.

@WtfJoke WtfJoke marked this pull request as ready for review Sep 3, 2021
@WtfJoke WtfJoke mentioned this pull request Sep 3, 2021
Copy link

@hectorgrecco hectorgrecco left a comment

LGTM

@MikkelHornJP
Copy link

@MikkelHornJP MikkelHornJP commented Sep 8, 2021

looking forward to getting this merged :-)

@WtfJoke
Copy link
Contributor Author

@WtfJoke WtfJoke commented Sep 13, 2021

@dmitry-shibanov I usually dont like to ping people, but is this something you can review? 🙂

@therynamo
Copy link

@therynamo therynamo commented Sep 14, 2021

Would love this feature! 😄 Really looking forward to it.

I was just following this blog https://avraam.dev/posts/reducing-github-action-time and was going to use that feature with this action - but I see it is not supported yet

@julada
Copy link

@julada julada commented Sep 22, 2021

Could you please review these simple changes @MaksimZhukov?

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Sep 23, 2021

Hello everyone. Sorry for the late reply.
@WtfJoke, Could you please run the npm ci && npm run build command with npm 6.x.

@WtfJoke
Copy link
Contributor Author

@WtfJoke WtfJoke commented Sep 23, 2021

@WtfJoke, Could you please run the npm ci && npm run build command with npm 6.x.

That was it thanks! I rebased and force pushed the changes :) Feel free to review it now @dmitry-shibanov

@MaksimZhukov MaksimZhukov merged commit 270253e into actions:main Sep 24, 2021
95 checks passed
@MaksimZhukov
Copy link
Contributor

@MaksimZhukov MaksimZhukov commented Sep 24, 2021

Hello @WtfJoke! Thank you for the contribution and sorry for the inconvenience!
We will release a new action version early next week.

@WtfJoke
Copy link
Contributor Author

@WtfJoke WtfJoke commented Sep 24, 2021

No worries :) Thanks for merging.
Glad I could contribute something

Copy link

@358jackchong 358jackchong left a comment

Chong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants