Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error only if exit code is no zero. #358

Merged
merged 6 commits into from Dec 27, 2021

Conversation

dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Nov 8, 2021

Description:
In scope of this pull request we resolve the issue related to warning can produce error. Sometimes warning can be written to stderr output, but exit code is 0. We have to add a check to throw error only if exit code is not null.

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov dmitry-shibanov marked this pull request as ready for review Dec 14, 2021
@dmitry-shibanov dmitry-shibanov changed the title Throw error only if exit code is node zero and error output is not null. Throw error only if exit code is note zero. Dec 27, 2021
@dmitry-shibanov dmitry-shibanov merged commit 9a74eb4 into actions:main Dec 27, 2021
98 checks passed
@dmitry-shibanov dmitry-shibanov changed the title Throw error only if exit code is note zero. Throw error only if exit code is no zero. Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants