Print node, npm and yarn versions after installation #368
Conversation
|
Hi, @havenchyk 👋 ! Thank you for your contribution! I'd suggest using getExecOutput() function instead of exec() to be able to format the information in the log and also to handle such situations when we want to notify user that there is no such util in the PATH (for instance the customer changed the PATH on the self-hosted runner and erased npm). Probably it'd be interesting to play with putting version information into the foldable group. |
|
📟 Just a gentle ping, @havenchyk |
|
Hello @havenchyk, just a gentle ping. |
|
hi guys, definitely I'll take a look: resolve conflicts today-tomorrow, thanks for reminders |
|
@dmitry-shibanov @IvanZosimov rebased, sorry for the delay |
|
oh, just noticed a comment about refactoring, let me address it |
|
@IvanZosimov can you please help me with the testing of changes? I see actions require some approval to run |
|
Hello @havenchyk. Could you please run |
|
@dmitry-shibanov done. I think we need to run some action to verify what will the code do. Before I fix the tests, I know they will fail |
|
Guys, I need help with testing :) which job should I check to understand that the version is printed correctly? |
| @@ -249,6 +249,21 @@ describe('setup-node', () => { | |||
|
|
|||
| let expPath = path.join(toolPath, 'bin'); | |||
|
|
|||
| expect(getExecOutputSpy).toHaveBeenCalledWith( | |||
There was a problem hiding this comment.
@dmitry-shibanov don't you think such check is better?
| core.setOutput(`${tool}-version`, output); | ||
| }); | ||
|
|
||
| await Promise.all(promises); |
There was a problem hiding this comment.
I didn't check it 😄
|
@dmitry-shibanov please take a look once again |
|
Hello @havenchyk. Thank you for contribution. Sorry for the late response. |
…ions#368) Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.3.0 to 8.4.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.3.0...v8.4.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description:
Print node, npm and yarn version as it was before #147
Related issue:
#90
Check list: