Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for asdf format as Node.js version file #373

Conversation

ganta
Copy link
Contributor

@ganta ganta commented Dec 2, 2021

Description:
I'm happy to be supported the Node.js version file in #338.
However, we're migrating Node.js version management to asdf.

The version specification file used in asdf has the following format, which is not supported by the current node-version-file input:

nodejs 14.18.2
ruby 2.7.4
nodejs 14.18.2
python 3.8.12

So, I implemented node-version-file to support the format asdf's .tool-versions file.

Related issue:
#222

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@ganta ganta changed the title Add support for asdf format as node version file Add support for asdf format as Node.js version file Dec 2, 2021
@ganta ganta force-pushed the add-support-for-asdf-format-as-node-version-file branch from 455bbf8 to 9f993b9 Compare Dec 5, 2021
@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented Jan 19, 2022

Hello @ganta. Thank you for your pull request. Could you please revert extra space changes in the yml file and run the npm run build command to regenerate dist directory.

@ganta ganta force-pushed the add-support-for-asdf-format-as-node-version-file branch from 9f993b9 to 4b5f062 Compare Jan 19, 2022
@ganta
Copy link
Contributor Author

ganta commented Jan 19, 2022

@dmitry-shibanov
Thank you for your review.

I reverted extra space changes and regenerated dist directory.
Please review again.

Thanks.

@dmitry-shibanov
Copy link
Contributor

dmitry-shibanov commented May 30, 2022

Hello @ganta. Sorry for the late response. Could you please sync with the main branch ?

@ganta ganta force-pushed the add-support-for-asdf-format-as-node-version-file branch from 4b5f062 to 8611828 Compare May 30, 2022
@ganta ganta requested a review from a team as a code owner May 30, 2022
@ganta ganta force-pushed the add-support-for-asdf-format-as-node-version-file branch from 8611828 to dbb64ac Compare May 30, 2022
@ganta
Copy link
Contributor Author

ganta commented May 30, 2022

I have synced with the main branch and some tests are now failing.
I will fix them.

@ganta ganta changed the title Add support for asdf format as Node.js version file [WIP] Add support for asdf format as Node.js version file May 30, 2022
@ganta ganta marked this pull request as draft May 30, 2022
@ganta ganta changed the title [WIP] Add support for asdf format as Node.js version file Add support for asdf format as Node.js version file May 30, 2022
@ganta
Copy link
Contributor Author

ganta commented May 30, 2022

Hi @dmitry-shibanov.

I have synced with the main branch and some tests are now failing.
I will fix them.

The test failed because the local environment was M1 Mac.
I have created another Pull Request to resolve that issue. #502

This Pull Request #373 has passed all checks, could you review it again?

@ganta ganta marked this pull request as ready for review May 30, 2022
@Timmitry
Copy link

Timmitry commented Jul 11, 2022

Bumping here as this PR would be of great interest for us, too 😇 Anything that is still missing here?

@marko-zivic-93 marko-zivic-93 merged commit 5b949b5 into actions:main Jul 11, 2022
110 checks passed
@ganta ganta deleted the add-support-for-asdf-format-as-node-version-file branch Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants