Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend documentation on scope parameter #470

Merged
merged 1 commit into from Apr 19, 2022
Merged

extend documentation on scope parameter #470

merged 1 commit into from Apr 19, 2022

Conversation

tyrann0us
Copy link
Contributor

@tyrann0us tyrann0us commented Apr 19, 2022

Description:
In writeRegistryToFile() (added in https://github.com/actions/setup-node/pull/21/files#diff-a3c83546a6fde2740e1dd05c8267c74af1c8a7fe3add285eea3669b3760ac6f3R25-R27), scope falls back to the repository owner if the npm.pkg.github.com registry (GitHub Packages) is used.
Since in most cases, this means that the scope parameter is not needed, but the logic is not documented anywhere, this PR adds the appropriate note to the parameter description.

Related issue:
None.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

This also ends all descriptions with a full stop (`.`).
@tyrann0us tyrann0us requested a review from a team as a code owner Apr 19, 2022
tyrann0us added a commit to inpsyde/reusable-workflows that referenced this pull request Apr 19, 2022
Copy link
Contributor

@brcrista brcrista left a comment

thanks!

@brcrista brcrista requested a review from dmitry-shibanov Apr 19, 2022
@brcrista
Copy link
Contributor

brcrista commented Apr 19, 2022

@dmitry-shibanov FYI

@brcrista brcrista merged commit 86bf502 into actions:main Apr 19, 2022
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants