Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Python version in pip cache key #303

Merged
merged 2 commits into from Jan 31, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 16, 2021

Description:

Like we do for pipenv, let's include the Python version in the pip cache key.

Without it, PyPy jobs continually build wheels from source, which is slow, and they never make it into the pip cache because there are prebuilt wheels for CPython jobs already in the cache.

Related issue:

Fixes #288.
Fixes #304.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov
Copy link
Contributor

Hello @hugovk. Thank you for your pull request. Could you please sync with the main branch and run the npm run release command.

@hugovk hugovk force-pushed the pip-cache-python-version branch from 45cf4cf to 95b9974 Compare Dec 24, 2021
@hugovk
Copy link
Contributor Author

hugovk commented Dec 24, 2021

Done! After npm install and npm run release, there were unstaged changes in package-lock.json, but I didn't commit it, just the auto-staged dist/setup/index.js changed.

@hugovk hugovk force-pushed the pip-cache-python-version branch from eba23d0 to 7ccd7e6 Compare Jan 1, 2022
@hugovk
Copy link
Contributor Author

hugovk commented Jan 1, 2022

Not sure why these are failing, they pass on my fork: https://github.com/hugovk/setup-python/actions/runs/1643387334

@dmitry-shibanov
Copy link
Contributor

Hello @hugovk. Sorry for the late response. Could please sync with the main branch. Builds should be fixed.

@hugovk hugovk force-pushed the pip-cache-python-version branch from 7ccd7e6 to fcd6854 Compare Jan 26, 2022
@hugovk
Copy link
Contributor Author

hugovk commented Jan 26, 2022

Rebased and CI passes, thanks!

@MaksimZhukov MaksimZhukov merged commit ba33a69 into actions:main Jan 31, 2022
106 checks passed
@MaksimZhukov
Copy link
Contributor

Hello @hugovk! Thank you for the contribution!

@hugovk hugovk deleted the pip-cache-python-version branch Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants