Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pypyX.Y for PyPy python-version input #349

Merged
merged 1 commit into from May 18, 2022
Merged

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Mar 5, 2022

Description:
Use pypyX.Y for PyPy python-version input

This versioning scheme is consistent with other tools in the python ecosystem so it feels more natural and allows better interaction with other tools.

pypy-X.Y kept for backward compatibility.

Full rationale provided in #346.

Related issue:
fixes #346

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@mayeut mayeut changed the title Use pypyX.Y for PyPy python-version input Use pypyX.Y for PyPy python-version input Mar 5, 2022
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Mar 5, 2022

An example can be seen here: https://github.com/mayeut/packaging/runs/5434696104?check_suite_focus=true
The associated workflow definition can be found here:
https://github.com/mayeut/packaging/blob/10d1ce220fd1847c9635190d45e72e7c1365644d/.github/workflows/test.yml#L17-L37
The diff to previous workflow file:

       matrix:
        os: [Ubuntu, Windows, macOS]
        python_version:
-         ["3.7", "3.8", "3.9", "3.10", "pypy-3.7", "pypy-3.8", "pypy-3.9"]
+         ["3.7", "3.8", "3.9", "3.10", "pypy3.7", "pypy3.8", "pypy3.9"]

    steps:
      - uses: actions/checkout@v1

      - uses: mayeut/setup-python@install-pypyX.Y-symlinks
      - uses: mayeut/setup-python@pypyX.Y
        name: Install Python ${{ matrix.python_version }}
        with:
          python-version: ${{ matrix.python_version }}

      - name: Run nox
-       run: |
-         INTERPRETER_SPEC=${{ matrix.python_version }}
-         INTERPRETER_SPEC=${INTERPRETER_SPEC/-/}  # remove '-' in "pypy-3.x" -> "pypy3.x" to match executable name
-         pipx run nox --error-on-missing-interpreters -s tests-${INTERPRETER_SPEC}
-       shell: bash
+       run: pipx run nox --error-on-missing-interpreters -s tests-${{ matrix.python_version }}

@mayeut mayeut force-pushed the pypyX.Y branch 3 times, most recently from a9cf09d to 843ba5d Compare Apr 9, 2022
@mayeut mayeut mentioned this pull request Apr 28, 2022
2 tasks
@mayeut mayeut marked this pull request as ready for review Apr 28, 2022
@mayeut mayeut requested a review from as a code owner Apr 28, 2022
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Apr 28, 2022

The 4 failing pypy-3.7-nightly tests are related to https://buildbot.pypy.org/nightly/ being down.

@mayeut
Copy link
Contributor Author

@mayeut mayeut commented May 7, 2022

@vsafonkin, @dmitry-shibanov,

do you know when you'll be able to review this ?
any clarification needed on my part ?

src/find-pypy.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented May 7, 2022

Hello @mayeut. Could you please also sync with the main branch ?

README.md Show resolved Hide resolved
@mayeut mayeut force-pushed the pypyX.Y branch 2 times, most recently from d8c69b7 to 98b28db Compare May 7, 2022
This versioning scheme is consistent with other
tools in the python ecosystem so it feels more natural
and allows better interaction with other tools.

fixes actions#346
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented May 7, 2022

thanks for the review @dmitry-shibanov, all your comments have been addressed.

@vsafonkin vsafonkin merged commit fff15a2 into actions:main May 18, 2022
104 checks passed
@vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented May 18, 2022

@mayeut, thank you for your contribution!

@mayeut mayeut deleted the pypyX.Y branch May 18, 2022
@EwoutH
Copy link

@EwoutH EwoutH commented May 19, 2022

Could a new release be tagged, to be able to use this syntax?

@vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented May 19, 2022

Could a new release be tagged, to be able to use this syntax?

Hi @EwoutH, a new version of the action will be released in the coming days.

@EwoutH
Copy link

@EwoutH EwoutH commented May 24, 2022

Hi @EwoutH, a new version of the action will be released in the coming days.

Awesome, looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants