Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache hit output #373

Merged
merged 6 commits into from Apr 5, 2022
Merged

Cache hit output #373

merged 6 commits into from Apr 5, 2022

Conversation

dhvcc
Copy link
Contributor

@dhvcc dhvcc commented Apr 3, 2022 •
edited

Description:

  • Added cache-hit output
  • Removed useless awaits in cache-restore tests

Related issue:
closes #371. Test action run is here

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dhvcc dhvcc requested a review from as a code owner Apr 3, 2022
@dhvcc
Copy link
Contributor Author

@dhvcc dhvcc commented Apr 3, 2022

I'm not actually sure if removing awaits belongs in this PR. I also noticed there were no tests for another output - python-version. So may be it makes sense to revisit tests and clean them up or add necessary ones?

@dhvcc
Copy link
Contributor Author

@dhvcc dhvcc commented Apr 3, 2022

Seems like those fails are unrelated to code. I can take a look at the workflows themselves if people are busy

dmitry-shibanov
dmitry-shibanov reviewed Apr 3, 2022
View changes
src/cache-distributions/cache-distributor.ts Outdated Show resolved Hide resolved
src/cache-distributions/cache-distributor.ts Outdated Show resolved Hide resolved
src/cache-distributions/cache-distributor.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@dhvcc
Copy link
Contributor Author

@dhvcc dhvcc commented Apr 4, 2022

Rebased PR to include fixed pipenv workflows.

And just for consistency, shouldn't we try use the same function as actions/cache?

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 5, 2022

Hello @dhvcc. I think it should work because the action sets the keys, that is why I consider it will be enough.

@brcrista brcrista merged commit 21c0493 into actions:main Apr 5, 2022
96 checks passed
@dhvcc
Copy link
Contributor Author

@dhvcc dhvcc commented Apr 5, 2022

Thanks, @brcrista @dmitry-shibanov. I wonder if there will be a release soon? I'll need this commit in a workflow, but don't want to enter commit hash.

@dmitry-shibanov
Copy link
Contributor

@dmitry-shibanov dmitry-shibanov commented Apr 5, 2022

Hello @dhvcc. I think we'll release it on this week.

adilosa added a commit to adilosa/setup-python that referenced this issue Apr 19, 2022
@adilosa
Merge remote-tracking branch 'upstream/main'
a200bff 
* upstream/main: (33 commits)
  Fix virtual-env toolcache links
  Updated @actions/cache (actions#382)
  ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379)
  Cache hit output (actions#373)
  Add pyton-version to setup PyPy output (actions#365)
  Rework pipenv caching test (actions#375)
  Update README.md to fix setup-python version  in example (actions#368)
  dist fix (actions#367)
  Cache on ghes (actions#363)
  Update dist
  Use `\n` instead of `os.EOL`
  Update dist
  Initialise pyproject.toml
  Build and format
  Remove console.log
  Remove unused file
  Reduce test matrix
  Parse values from poetry
  Release
  Add more tests
  ...
@plazum plazum mentioned this pull request Jun 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-shibanov dmitry-shibanov

@brcrista brcrista

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce cache-hit output
3 participants
@dhvcc @dmitry-shibanov @brcrista