Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pipenv caching test #375

Merged
merged 7 commits into from Apr 4, 2022

Conversation

vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented Apr 3, 2022

Description:
Pipenv cache tests are broken at the moment. Example of the failed run: link

In order to fix these tests:

  • Added Pipfile with numpy and pandas packages to avoid of creating new pipenv environment each time (pipenv creates new environment if Pipfile is not exist). The versions of numpy and pandas are hardcoded in the Pipfile to avoid regenerating cache.
  • Regenerated Pipfile.lock according new Pipfile
  • Added txt file for pipenv cache tests with dependency path
  • Bump to actions/checkout@v3

Test build: link

Related issue:
#376

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@vsafonkin vsafonkin marked this pull request as ready for review Apr 4, 2022
@vsafonkin vsafonkin requested a review from as a code owner Apr 4, 2022
@brcrista brcrista merged commit 7885ec3 into actions:main Apr 4, 2022
96 checks passed
@vsafonkin vsafonkin deleted the v-vsafonkin/fix-pipenv-cache-test branch Apr 4, 2022
adilosa added a commit to adilosa/setup-python that referenced this issue Apr 19, 2022
* upstream/main: (33 commits)
  Fix virtual-env toolcache links
  Updated @actions/cache (actions#382)
  ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379)
  Cache hit output (actions#373)
  Add pyton-version to setup PyPy output (actions#365)
  Rework pipenv caching test (actions#375)
  Update README.md to fix setup-python version  in example (actions#368)
  dist fix (actions#367)
  Cache on ghes (actions#363)
  Update dist
  Use `\n` instead of `os.EOL`
  Update dist
  Initialise pyproject.toml
  Build and format
  Remove console.log
  Remove unused file
  Reduce test matrix
  Parse values from poetry
  Release
  Add more tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants