Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign default value of AGENT_TOOLSDIRECTORY if not set #394

Merged

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Apr 28, 2022

Description:
This is a proof of concept PR to eliminate the need of explicit setting AGENT_TOOLSDIRECTORY variable

Ubuntu demo build
https://github.com/akv-demo/setup-python-test/runs/6205091860?check_suite_focus=true

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame requested a review from a team as a code owner Apr 28, 2022
@noymer
Copy link

noymer commented Jun 13, 2022

If $AGENT_TOOLSDIRECTORY is not set,
$RUNNER_TOOL_CACHE is used by default.
So, it is not necessary to set $AGENT_TOOLSDIRECTORY .
https://github.com/actions/python-versions/blob/bf3c64f9507de9c1bb3ee183922017dbae7f6bbd/installers/nix-setup-template.sh#L11-L16

This change will make this action stop working on the environment which doesn't have /opt/hostedtoolcache directory.

I guess README has to be changed to refer to $RUNNER_TOOL_CACHE .

@dsame dsame force-pushed the v-sedoli/set-env-by-default branch from 7835f99 to 9c76df2 Compare Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants