Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if python version set to empty value #396

Merged
merged 5 commits into from May 4, 2022

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Apr 29, 2022

Description:
There was a request to add non-zero exit in case if python-version input set to zero value, but @dmitry-shibanov warned it might break the existing builds.

I suggest to add a warning to the log instead of of non-zero exit code.

There's a build confirming no tool-cache python installed if python-version is empty.

Related issue:
related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame requested a review from a team as a code owner Apr 29, 2022
src/setup-python.ts Outdated Show resolved Hide resolved
src/setup-python.ts Outdated Show resolved Hide resolved
dsame and others added 2 commits May 4, 2022
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
@marko-zivic-93 marko-zivic-93 merged commit fd8f0a9 into actions:main May 4, 2022
96 checks passed
@dsame dsame deleted the v-sedoli/issue-241 branch May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants