Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a python-path output #405

Merged
merged 1 commit into from May 25, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 22, 2022

Description:
Expose a python-path output containing the chosen Python executable path.

Related issue:
fix #309
mitigate #132

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@mayeut mayeut requested a review from as a code owner May 22, 2022
action.yml Outdated Show resolved Hide resolved
@mayeut mayeut changed the title feature: add an interpreter-path output feature: add a python-path output May 23, 2022
.github/workflows/test-python.yml Outdated Show resolved Hide resolved
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented May 24, 2022

The failure for e2e-cache / Test poetry (Python pypy-3.7-v7.x, windows-latest) seems unrelated to changes in this PR.

@vsafonkin
Copy link
Contributor

@vsafonkin vsafonkin commented May 24, 2022

Hi @mayeut, why you don't want to use pythonLocation environment variable for this purpose?

@henryiii
Copy link

@henryiii henryiii commented May 24, 2022

The output works doesn't rely on modifying the environment, and doesn't get overwritten. So you could do multiple setup-python's, and access the correct output. An example of this might be problematic:

- uses: actions/setup-python@v3
  with:
    python-version: "3.7"
- uses: some/composite-action@v1 # Runs a different setup-python internally
# Now pythonLocation is no longer the 3.7 one!

.github/workflows/test-python.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
Expose a `python-path` output containing the chosen Python executable path.
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented May 24, 2022

The failure for e2e-cache / Test poetry (Python pypy-3.7-v7.x, windows-latest) seems unrelated to changes in this PR.
(the previous failure on the same test went away with a relaunch of the workflow by @vsafonkin)

@marko-zivic-93 marko-zivic-93 merged commit 081a3cf into actions:main May 25, 2022
104 checks passed
@mayeut mayeut deleted the interpreter-path branch May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants