Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake hints #440

Merged
merged 3 commits into from Jun 30, 2022
Merged

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Jun 22, 2022

Description:

FindPythonNNN CMake modules uses the environment variables to find the specific version of Python

The change is similar to setting pythonLocation and PKG_CONFIG_PATH env. variables.

Related issue:
#231

@vsafonkin
Copy link
Contributor

vsafonkin commented Jun 27, 2022

I'm not sure that we should add some custom environment variables for any tools to the action. There are many tools with a lot of environment variables to configure it, are we going to add more and more of them further? I think it should happen from the customers side.

@dsame dsame closed this Jun 28, 2022
@dsame dsame reopened this Jun 28, 2022
@dsame
Copy link
Contributor Author

dsame commented Jun 28, 2022

I'm not sure that we should add some custom environment variables for any tools to the action. There are many tools with a lot of environment variables to configure it, are we going to add more and more of them further? I think it should happen from the customers side.

cmake is very important tool and it is expected to work out of box. It works with default python installation without extra configuration, so we should keep the same behaviour.

@marko-zivic-93 marko-zivic-93 merged commit ab6deb3 into actions:main Jun 30, 2022
151 checks passed
@vsafonkin vsafonkin deleted the v-sdolin/issue-231 branch Jun 30, 2022
mayeut added a commit to mayeut/setup-python that referenced this pull request Jul 2, 2022
actions#440 duplicated a block of code outside of `if (updateEnvironment) {` condition. This was probably an oversight when merging `main` back on the PR branch. The tests should have seen that `core.exportVariable` was being called and should have failed.
mayeut added a commit to mayeut/setup-python that referenced this pull request Jul 2, 2022
actions#440 duplicated a block of code outside of `if (updateEnvironment) {` condition. This was probably an oversight when merging `main` back on the PR branch. The tests should have seen that `core.exportVariable` was being called and should have failed.
marko-zivic-93 added a commit that referenced this pull request Jul 6, 2022
Remove duplicate code introduced in #440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants