Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code introduced in #440 #452

Merged
merged 2 commits into from Jul 6, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jul 2, 2022

Description:
#440 duplicated a block of code outside of if (updateEnvironment) { condition. This was probably an oversight when merging main back on the PR branch. The tests should have seen that core.exportVariable was being called and should have failed.

Related issue:
relates to #440

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

mayeut added 2 commits Jul 2, 2022
actions#440 duplicated a block of code outside of `if (updateEnvironment) {` condition. This was probably an oversight when merging `main` back on the PR branch. The tests should have seen that `core.exportVariable` was being called and should have failed.
@mayeut mayeut requested a review from a team as a code owner Jul 2, 2022
@marko-zivic-93 marko-zivic-93 merged commit 0ad0f6a into actions:main Jul 6, 2022
151 checks passed
@mayeut mayeut deleted the fix-env branch Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants