Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): coloured logs #465

Merged
merged 5 commits into from Jun 2, 2021
Merged

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented May 25, 2021

Changes

Fixes #459

@C0ZEN C0ZEN marked this pull request as ready for review May 25, 2021
@C0ZEN C0ZEN requested a review from a team as a code owner May 25, 2021
C0ZEN added 4 commits May 25, 2021
I was not able to disable or mock ansi-styles so instead I found a way to make the tests pass
it's not perfect but it's still nice because the logs will keep their trustful colour when running through the tests
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jun 1, 2021

@luketomlinson would be nice if you could merge this one

Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 Nice work!

@luketomlinson luketomlinson merged commit 5fbbfba into actions:main Jun 2, 2021
4 checks passed
@C0ZEN C0ZEN deleted the fix/coloured-logs branch Jun 27, 2021
jaho8 referenced this pull request May 16, 2022
#224)

* docs(readme): add new options in the documentation

* chore: update the action schema

* chore: parse the new arguments

* feat(stale-and-close): add new options to change the days before close

to avoid a breaking change and simplify the configuration the old options 'daysBeforeStale' and 'daysBeforePrClose' are kept and new options are available to override them with 'daysBeforeIssueStale', 'daysBeforePrStale', 'daysBeforeIssueClose' and 'daysBeforePrClose'

* chore: rename the issue type enum to remove the enum suffix

* chore: add missing dependency for eslint and typescript

also upgrade the parser

* chore: fix an issue with the linter for the shadow rules

it was not configured properly for TypeScript

* chore: use camelCase for constants

* chore: use camelCase for enum members

* chore: fix the tests

* chore: enhance prettier to also lint other kind of files

it was configured to only work with ts and it was not working well to be honest
also now the lint scripts will also run prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub logs not coloured
2 participants