Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operations): fail fast the current batch to respect the operations limit #474

Merged
merged 6 commits into from Jun 7, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jun 2, 2021

Changes

  • fix a bad stats related to the consumed operations
  • display the stats when the operations per run stopped the workflow
  • fail fast the current batch to respect the operations limit, fixes operations-per-run appears to be ignored #466
  • disable the dry-run for the test by default

@C0ZEN C0ZEN requested a review from a team as a code owner Jun 2, 2021
C0ZEN added 6 commits Jun 3, 2021
…s limit

Instead of processing an entire batch of 100 issues before checking the operations left, simply do it before processing an issue so that we respect as expected the limitation of the operations per run
Fixes actions#466
we will be able to test the operations per run and have more complete logs that could help us debug the workflow
@C0ZEN C0ZEN force-pushed the fix/operations-fail-fast branch from ad17c44 to 2f93a2a Compare Jun 3, 2021
@luketomlinson luketomlinson merged commit 5f6f311 into actions:main Jun 7, 2021
4 checks passed
@C0ZEN C0ZEN deleted the fix/operations-fail-fast branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operations-per-run appears to be ignored
2 participants