Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): remove common options between the issues and PRs #586

Merged
merged 11 commits into from Oct 19, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Oct 8, 2021

Changes

See the commits.
⚠️ please don't squash on merge, keep the commit like this; it will be way easier if there is a bug to debug and also to have a better changelog generated out of this!

Context

Remove the common options to favour using only PR and issues options.
This is reducing a lot the code base, the complexity, and the number of tests.
The documentation was also split to reflect this.

Closes #493

C0ZEN added 10 commits Oct 8, 2021
BREAKING CHANGE:
The option ignore-updates was removed
BREAKING CHANGE:
The option exempt-all-assignees was removed
BREAKING CHANGE:
The option exempt-assignees was removed
BREAKING CHANGE:
The option exempt-all-milestones was removed
BREAKING CHANGE:
The option exempt-milestones was removed
BREAKING CHANGE:
The option any-of-labels was removed
BREAKING CHANGE:
The option only-labels was removed
BREAKING CHANGE:
The option only-labels was removed
BREAKING CHANGE:
The option days-before-stale was removed
BREAKING CHANGE:
The option remove-stale-when-updated was removed
@C0ZEN C0ZEN requested a review from a team as a code owner Oct 8, 2021
@C0ZEN C0ZEN changed the title feat: remove the ignore-updates option feat: remove common options between the issues and PRs Oct 8, 2021
@C0ZEN C0ZEN force-pushed the feature/split-pr-and-issue-options branch from 8db9046 to 6700440 Compare Oct 8, 2021
@C0ZEN C0ZEN changed the title feat: remove common options between the issues and PRs feat(options): remove common options between the issues and PRs Oct 17, 2021
Copy link
Collaborator

@luketomlinson luketomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @C0ZEN this is great

@luketomlinson luketomlinson merged commit db699ab into actions:main Oct 19, 2021
5 checks passed
@C0ZEN C0ZEN deleted the feature/split-pr-and-issue-options branch Oct 19, 2021
luketomlinson added a commit that referenced this pull request Oct 20, 2021
…-options"

This reverts commit db699ab, reversing
changes made to b83d488.
luketomlinson added a commit that referenced this pull request Oct 20, 2021
Revert "Merge pull request #586 from C0ZEN/feature/split-pr-and-issue…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the documentation and the options between issues and PRs
2 participants