Fix for logging error types instead of strings in the main try/catch #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failure in |
pjquirk
commented
May 12, 2020
| @@ -374,7 +376,12 @@ export class IssueProcessor { | |||
| event => event.event === 'labeled' && event.label.name === label | |||
| ); | |||
|
|
|||
| return staleLabeledEvent!.created_at; | |||
| if (!staleLabeledEvent) { | |||
There was a problem hiding this comment.
awesome. thanks for fixing my bad code :)
hross
approved these changes
May 12, 2020
| @@ -374,7 +376,12 @@ export class IssueProcessor { | |||
| event => event.event === 'labeled' && event.label.name === label | |||
| ); | |||
|
|
|||
| return staleLabeledEvent!.created_at; | |||
| if (!staleLabeledEvent) { | |||
There was a problem hiding this comment.
awesome. thanks for fixing my bad code :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
Errortype is thrown instead of astring, the commandcore.error(error)itself would fail, which would mask the real error. This generally results in an error that is described in actions/toolkit#398.This bug has been fixed in 1.2.4 of
@actions/core, so let's just use that version.